From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [mickledore][PATCH] Revert "yq: Redefine do_compile"
Date: Mon, 26 Jun 2023 18:50:39 -0400 [thread overview]
Message-ID: <ZJoWP4TRjMLbxi2l@gmail.com> (raw)
In-Reply-To: <20230626122610.2729201-1-Martin.Jansa@gmail.com> <20230626162711.3354372-1-Martin.Jansa@gmail.com>
both mickledore patches are merged.
Bruce
In message: [mickledore][PATCH] Revert "yq: Redefine do_compile"
on 26/06/2023 Martin Jansa wrote:
> From: Bruce Ashfield <bruce.ashfield@gmail.com>
>
> This reverts commit 49a6827cbdb6e00d3af5e5c4a4479c47573a4533.
>
> The workaround is no longer needed, as oe-core has upgraded go to
> a version that has fixed the issue.
>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> ---
> recipes-devtools/yq/yq_git.bb | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/recipes-devtools/yq/yq_git.bb b/recipes-devtools/yq/yq_git.bb
> index bd474a7..45f2f97 100644
> --- a/recipes-devtools/yq/yq_git.bb
> +++ b/recipes-devtools/yq/yq_git.bb
> @@ -50,7 +50,7 @@ GO_IMPORT = "github.com/mikefarah/yq"
>
> inherit go ptest
>
> -do_compile() {
> +do_compile:prepend() {
> # arrange for some of the golang built ins to be found
> (
> cd ${WORKDIR}/build/src/
> @@ -60,7 +60,6 @@ do_compile() {
> # arrange for the fetched dependencies to be found
> export GOPATH="${GOPATH}:${WORKDIR}/build/vendor/"
> export GO111MODULE=off
> - ${GO} install ${GOBUILDFLAGS} `go_list_packages`
> }
>
> do_install:append() {
> --
> 2.41.0
>
In message: [mickledore][PATCH] libvmi: add dependency on autoconf-archive-native
on 26/06/2023 Martin Jansa wrote:
> * since https://git.openembedded.org/openembedded-core/commit/?id=571132415ea7fe2d91c62948f2b6aa553eafa83d
> this doesn't get autoconf-archive-native dependency and fails with:
> http://errors.yoctoproject.org/Errors/Details/708195/
>
> ./configure: line 14424: syntax error near unexpected token `-fno-strict-overflow,'
> ./configure: line 14424: ` AX_CHECK_COMPILE_FLAG(-fno-strict-overflow, HARDEN_CFLAGS="$HARDEN_CFLAGS -fno-strict-overflow", , -Werror )'
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> ---
> recipes-extended/libvmi/libvmi_git.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/libvmi/libvmi_git.bb b/recipes-extended/libvmi/libvmi_git.bb
> index 6338b80..25d7d40 100644
> --- a/recipes-extended/libvmi/libvmi_git.bb
> +++ b/recipes-extended/libvmi/libvmi_git.bb
> @@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYING.LESSER;md5=e6a600fd5e1d9cbde2d983680233ad02"
> SECTION = "console/tools"
> PV = "0.14.0+git${SRCPV}"
>
> -DEPENDS = "libvirt libcheck bison fuse bison-native flex-native"
> +DEPENDS = "libvirt libcheck bison fuse bison-native flex-native autoconf-archive-native"
>
> SRC_URI = "git://github.com/libvmi/libvmi.git;branch=master;protocol=https \
> file://0001-Build-vbd-only-when-xen-is-enabled.patch \
> --
> 2.41.0
>
prev parent reply other threads:[~2023-06-26 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 12:26 [mickledore][PATCH] libvmi: add dependency on autoconf-archive-native Martin Jansa
2023-06-26 16:27 ` [mickledore][PATCH] Revert "yq: Redefine do_compile" Martin Jansa
2023-06-26 22:50 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJoWP4TRjMLbxi2l@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=martin.jansa@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).