From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: "Theodore A. Roth" <troth@openavr.org>
Cc: lukasz.czechowski@thaumatec.com,
meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH v2] podman: fix location of user systemd service units
Date: Tue, 30 Apr 2024 22:29:47 -0400 [thread overview]
Message-ID: <CADkTA4Pre5J9Zu-mj6_9jNP=4DMCuxch-YMe5E4Fh8JGUFNucQ@mail.gmail.com> (raw)
In-Reply-To: <CAFMvBt0fxFbmJwnXr1LSCyK2o+DK=tmBzfzQNQ8qiROaiXb-VQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]
On Tue, Apr 30, 2024 at 10:45 AM Theodore A. Roth <troth@openavr.org> wrote:
>
>
> On Mon, Apr 22, 2024 at 9:03 AM Bruce Ashfield via lists.yoctoproject.org
> <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>
>> merged to master and scarthgap.
>>
>> Bruce
>>
>> In message: [meta-virtualization][PATCH v2] podman: fix location of user
>> systemd service units
>> on 17/04/2024 lukasz.czechowski@thaumatec.com wrote:
>>
>> > From: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>
>> >
>> > The value of USERSYSTEMDDIR is currently set to
>> > ${systemd_unitdir}/user, which might not be present in user unit
>> > search path.
>> > Use dedicated bitbake variable ${systemd_user_unitdir} instead.
>> >
>> > Signed-off-by: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>
>> > Cc: Bruce Ashfield <bruce.ashfield@gmail.com>
>> > ---
>> > recipes-containers/podman/podman_git.bb | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/recipes-containers/podman/podman_git.bb
>> b/recipes-containers/podman/podman_git.bb
>> > index 3eadd202..f69dec16 100644
>> > --- a/recipes-containers/podman/podman_git.bb
>> > +++ b/recipes-containers/podman/podman_git.bb
>> > @@ -62,7 +62,7 @@ do_configure[noexec] = "1"
>> > EXTRA_OEMAKE = " \
>> > PREFIX=${prefix} BINDIR=${bindir} LIBEXECDIR=${libexecdir} \
>> > ETCDIR=${sysconfdir} TMPFILESDIR=${nonarch_libdir}/tmpfiles.d \
>> > - SYSTEMDDIR=${systemd_unitdir}/system
>> USERSYSTEMDDIR=${systemd_unitdir}/user \
>> > + SYSTEMDDIR=${systemd_unitdir}/system
>> USERSYSTEMDDIR=${systemd_user_unitdir} \
>> > "
>> >
>> > # remove 'docker' from the packageconfig if you don't want podman to
>> > @@ -134,7 +134,7 @@ do_install_ptest () {
>> > FILES:${PN} += " \
>> > ${systemd_unitdir}/system/* \
>> > ${nonarch_libdir}/systemd/* \
>> > - ${systemd_unitdir}/user/* \
>> > + ${systemd_user_unitdir/* \
>>
>
> Just noticed that this is missing the closing brace. This typo is on
> master and scarthgap branches.
>
> Would you like me to send a patch?
>
>
Sure! I'm doing some other major package additions and updates right now,
so a patch is easier for me.
Bruce
> Ted Roth
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
[-- Attachment #2: Type: text/html, Size: 4569 bytes --]
prev parent reply other threads:[~2024-05-01 2:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 22:56 [meta-virtualization][PATCH v2] podman: fix location of user systemd service units lukasz.czechowski
2024-04-22 15:03 ` Bruce Ashfield
2024-04-30 14:45 ` Theodore A. Roth
2024-05-01 2:29 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADkTA4Pre5J9Zu-mj6_9jNP=4DMCuxch-YMe5E4Fh8JGUFNucQ@mail.gmail.com' \
--to=bruce.ashfield@gmail.com \
--cc=lukasz.czechowski@thaumatec.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=troth@openavr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).