From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Fathi Boudra <fathi.boudra@linaro.org>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] upx: bump to 4.2.2 release
Date: Mon, 12 Feb 2024 11:00:23 -0500 [thread overview]
Message-ID: <CADkTA4ONr5V9m___z91ErfQC8dHrO1rh1pMGpBxp+s0kj7GKxA@mail.gmail.com> (raw)
In-Reply-To: <CAGNsrLByF3O5ZE__gvYJFfzqWPEAFt-a1zXRCUMZmh8pYr8B2w@mail.gmail.com>
On Mon, Feb 12, 2024 at 10:53 AM Fathi Boudra <fathi.boudra@linaro.org> wrote:
>
> Hi Bruce,
>
> On Mon, 12 Feb 2024 at 16:21, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
> >
> > On Mon, Feb 12, 2024 at 9:52 AM Fathi Boudra <fathi.boudra@linaro.org> wrote:
> > >
> > > Update upx recipe from 3.96 to 4.2.2 release.
> > > Use the released tarball instead of git repositories.
> > > Rewrite the recipe, simplified by using the latest released tarball.
> > > Update the homepage.
> >
> > I don't mind the update, but I do pretty much insist on git
> > repositories versus tarballs.
> >
> > So I'd take an update, but not the change of format of the recipe.
>
> Sure I can revert to using the git repositories. Do you mind expand on
> the rationale so I can add a note within the recipe? Thanks.
Having the individual SRCREVs makes maintenance much easier when we
have CVEs or other issues. Grabbing patches and putting them in the
SRC_URI is suboptimal, when there's a perfectly good git repository
available that already has them available.
Also, being able to easily access the history of a repository for
bisection and debug is important when I'm debugging system issues.
Bruce
>
> > Cheers,
> >
> > Bruce
> >
> > >
> > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> > > ---
> > > recipes-extended/upx/upx_4.2.2.bb | 14 ++++++++++
> > > recipes-extended/upx/upx_git.bb | 45 -------------------------------
> > > 2 files changed, 14 insertions(+), 45 deletions(-)
> > > create mode 100644 recipes-extended/upx/upx_4.2.2.bb
> > > delete mode 100644 recipes-extended/upx/upx_git.bb
> > >
> > > diff --git a/recipes-extended/upx/upx_4.2.2.bb b/recipes-extended/upx/upx_4.2.2.bb
> > > new file mode 100644
> > > index 00000000..cb46d19c
> > > --- /dev/null
> > > +++ b/recipes-extended/upx/upx_4.2.2.bb
> > > @@ -0,0 +1,14 @@
> > > +SUMMARY = "Ultimate executable compressor."
> > > +HOMEPAGE = "https://upx.github.io/"
> > > +LICENSE = "GPL-2.0-only"
> > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
> > > +DEPENDS = "libucl zlib xz"
> > > +
> > > +SRC_URI = "https://github.com/upx/upx/releases/download/v${PV}/upx-${PV}-src.tar.xz"
> > > +SRC_URI[sha256sum] = "42ee0455eea610ef7ee732aa1f657b34a351ebcfa64a24c1e2a7aaec74c1e038"
> > > +
> > > +S = "${WORKDIR}/upx-${PV}-src"
> > > +
> > > +inherit pkgconfig cmake
> > > +
> > > +BBCLASSEXTEND = "native"
> > > diff --git a/recipes-extended/upx/upx_git.bb b/recipes-extended/upx/upx_git.bb
> > > deleted file mode 100644
> > > index 2a5f08be..00000000
> > > --- a/recipes-extended/upx/upx_git.bb
> > > +++ /dev/null
> > > @@ -1,45 +0,0 @@
> > > -HOMEPAGE = "http://upx.sourceforge.net"
> > > -SUMMARY = "Ultimate executable compressor."
> > > -
> > > -SRCREV_upx = "8d1a98e03bf281b2cee459b6c27347e56d13c6a8"
> > > -SRCREV_vendor_doctest = "666e648b68fda2deb141a1fe93e3fd1e2795dd0f"
> > > -SRCREV_vendor_lzma_sdk = "9ebf8f468c689d83504e6c08c6bc26c4a1cf180f"
> > > -SRCREV_vendor_ucl = "4b58d592199dc1e5db691e1a54fb0e5e9af0ecaf"
> > > -SRCREV_vendor_zlib = "2a5b338eb173a701ed179e951d4c390e75e8d4c7"
> > > -SRCREV_FORMAT = "upx"
> > > -SRC_URI = "git://github.com/upx/upx;name=upx;branch=devel;protocol=https \
> > > - git://github.com/upx/upx-vendor-doctest;name=vendor_doctest;subdir=git/vendor/doctest;branch=upx-vendor;protocol=https \
> > > - git://github.com/upx/upx-vendor-lzma-sdk;name=vendor_lzma_sdk;subdir=git/vendor/lzma-sdk;branch=upx-vendor;protocol=https \
> > > - git://github.com/upx/upx-vendor-ucl;name=vendor_ucl;subdir=git/vendor/ucl;branch=upx-vendor;protocol=https \
> > > - git://github.com/upx/upx-vendor-zlib;name=vendor_zlib;subdir=git/vendor/zlib;branch=upx-vendor;protocol=https \
> > > -"
> > > -
> > > -LICENSE = "GPL-2.0-only"
> > > -LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
> > > -
> > > -DEPENDS = "zlib libucl xz cmake-native"
> > > -
> > > -# inherit cmake
> > > -
> > > -S = "${WORKDIR}/git"
> > > -
> > > -PV = "3.96+"
> > > -
> > > -EXTRA_OEMAKE += " \
> > > - UPX_UCLDIR=${STAGING_DIR_TARGET} \
> > > - UPX_LZMADIR=${STAGING_DIR_TARGET} \
> > > -"
> > > -
> > > -# FIXME: The build fails if security flags are enabled
> > > -SECURITY_CFLAGS = ""
> > > -
> > > -do_compile() {
> > > - oe_runmake -C src all
> > > -}
> > > -
> > > -do_install:append() {
> > > - install -d ${D}${bindir}
> > > - install -m 755 ${B}/build/release/upx ${D}${bindir}/upx
> > > -}
> > > -
> > > -BBCLASSEXTEND = "native"
> > > --
> > > 2.43.0
> > >
> > >
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#8563): https://lists.yoctoproject.org/g/meta-virtualization/message/8563
> > > Mute This Topic: https://lists.yoctoproject.org/mt/104312316/1050810
> > > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II
>
> Cheers,
> --
> Fathi Boudra
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
prev parent reply other threads:[~2024-02-12 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 14:52 [meta-virtualization][PATCH] upx: bump to 4.2.2 release Fathi Boudra
2024-02-12 15:20 ` Bruce Ashfield
2024-02-12 15:53 ` Fathi Boudra
2024-02-12 16:00 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADkTA4ONr5V9m___z91ErfQC8dHrO1rh1pMGpBxp+s0kj7GKxA@mail.gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=fathi.boudra@linaro.org \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).