From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
Cc: "meta-virtualization@lists.yoctoproject.org"
<meta-virtualization@lists.yoctoproject.org>,
"adrian.freihofer@gmail.com" <adrian.freihofer@gmail.com>
Subject: Re: [meta-virtualization] [PATCH RFC] kernel: allow KERNEL_META_TYPE redefinition
Date: Tue, 7 Nov 2023 09:11:51 -0500 [thread overview]
Message-ID: <CADkTA4NGhrRwZNfdi-2+SfhOqqMn5Tofakjvfyy1ebhcxVDnGg@mail.gmail.com> (raw)
In-Reply-To: <642e2c00f27c5897f333d3f73a1c723fd0740c4d.camel@siemens.com>
On Tue, Nov 7, 2023 at 8:57 AM Sverdlin, Alexander
<alexander.sverdlin@siemens.com> wrote:
>
> Thanks Bruce,
>
> On Tue, 2023-11-07 at 08:23 -0500, Bruce Ashfield wrote:
> > > > > Which is why if a kernel type that can merge fragments, but yet
> > > > > is disabling the feature specification, the layer should emit a
> > > > > warning. I'd then have another variable which inhibits the warning
> > > > > message. Since that is something I can ask about in bug reports
> > > > > and until the warning message is re-enabled, the reporter is on
> > > > > their own.
> > > >
> > > > My solution is now in master-next:
> > > >
> > > > https://git.yoctoproject.org/meta-virtualization/commit/?h=master-next&id=45c2297a916516e5fc7b82dab46c4719590813b7
> > >
> > > I've tested your solution and it solves the issue on my side,
> > > thank you for addressing it so quickly!
> > >
> > > There is a problem in the warning code though, namely a typo here:
> > >
> > > skip_kernel_include_enabled = d.getVar('SKIP_META_VIRT_KERNEL_INLUDE')
> > >
> > > if it would be
> > >
> > > skip_kernel_include_enabled = d.getVar('SKIP_META_VIRT_KERNEL_INCLUDE')
> > >
> > > the warning would be emitted as expected. After the change both emitting
> > > and silencing the warning works fine.
> >
> > oops!
> >
> > I just force pushed the fix to master-next.
>
> Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> if it matters
It does! Thanks for the confirmation.
Bruce
>
> --
> Alexander Sverdlin
> Siemens AG
> www.siemens.com
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
prev parent reply other threads:[~2023-11-07 14:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 10:24 use of yocto-cfg-fragments Sverdlin, Alexander
2023-11-02 19:13 ` Bruce Ashfield
2023-11-03 9:15 ` Sverdlin, Alexander
2023-11-03 12:51 ` Bruce Ashfield
[not found] ` <17941DFC88BEAF3E.3650@lists.yoctoproject.org>
2023-11-03 13:00 ` [meta-virtualization] " Bruce Ashfield
2023-11-03 13:13 ` Sverdlin, Alexander
2023-11-03 13:59 ` Bruce Ashfield
2023-11-03 14:21 ` Sverdlin, Alexander
2023-11-03 14:40 ` Bruce Ashfield
2023-11-06 9:20 ` [PATCH RFC] kernel: allow KERNEL_META_TYPE redefinition A. Sverdlin
2023-11-06 13:41 ` Bruce Ashfield
[not found] ` <17950C6F5A95F7ED.26468@lists.yoctoproject.org>
2023-11-07 0:57 ` [meta-virtualization] " Bruce Ashfield
2023-11-07 10:10 ` Sverdlin, Alexander
2023-11-07 13:23 ` Bruce Ashfield
2023-11-07 13:57 ` Sverdlin, Alexander
2023-11-07 14:11 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADkTA4NGhrRwZNfdi-2+SfhOqqMn5Tofakjvfyy1ebhcxVDnGg@mail.gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=adrian.freihofer@gmail.com \
--cc=alexander.sverdlin@siemens.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).