meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: bruce.ashfield@gmail.com
Cc: Marek Belisko <marek.belisko@gmail.com>,
	meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] nerdctl broken in kirkstone
Date: Wed, 13 Sep 2023 09:45:51 -0400	[thread overview]
Message-ID: <CADkTA4MFixZWj64GcwB0E+OKkSVySBC8m96+64qLvHcc212P4A@mail.gmail.com> (raw)
In-Reply-To: <17843A682EC729DC.10919@lists.yoctoproject.org>

On Tue, Sep 12, 2023 at 2:32 PM Bruce Ashfield via
lists.yoctoproject.org
<bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>
> On Tue, Sep 12, 2023 at 3:26 AM Marek Belisko <marek.belisko@gmail.com> wrote:
> >
> > Hi,
> >
> > Forwarding in proper mailing list.
> >
> > I'm trying to add nerdctl to an image using kirkstone release for meta-virtualization.
> > I've added bbappend with following fix:
> >
> > SRC_URI = "git://github.com/containerd/nerdctl.git;name=nerdcli;branch=main;protocol=https"
> >
> > (branch name in original recipe is master but main is required)
>
> Right, we have a fix in new release for that:
>
> commit cb5dfda6f6d862a575f029ee8ded0bc3db6bc766
> Author: Guenther Meyer <g.meyer@signum-media.de>
> Date:   Fri Nov 18 11:55:46 2022 +0100
>
>     nerdctl: renamed upstream branch master to main
>
>     Signed-off-by: Guenther Meyer <g.meyer@signum-media.de>
>     Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
>
> diff --git a/recipes-containers/nerdctl/nerdctl_git.bb
> b/recipes-containers/nerdctl/nerdctl_git.bb
> index 4a749b2..8fe5e7d 100644
> --- a/recipes-containers/nerdctl/nerdctl_git.bb
> +++ b/recipes-containers/nerdctl/nerdctl_git.bb
> @@ -13,7 +13,7 @@ DEPENDS = " \
>  SRCREV_FORMAT="nerdcli_cgroups"
>  SRCREV_nerdcli = "e084a2df4a8861eb5f0b0d32df0643ef24b81093"
>
> -SRC_URI = "git://github.com/containerd/nerdctl.git;name=nerdcli;branch=master;protocol=https"
> +SRC_URI = "git://github.com/containerd/nerdctl.git;name=nerdcli;branch=main;protocol=https"
>
>  include src_uri.inc
>
> ---------
>
> it could be cherry-picked to kirkstone, there's just no proactive
> cherry picking that
> is done, and I typically wait for someone with a real issue on the branch to ask
> for it.
>
> I can take this email as that request.
>
> >
> > but then anyways it fails with:
> >
> > rsync: [sender] change_dir "/data/projects/test/build/tmp/work/cortexa53-crypto-poky-linux/nerdctl/v0.18.0-r0/nerdctl-v0.18.0/src/import/vendor.fetch/github.com/Masterminds/semver/v3" failed: No such file or directory (2)
> > | rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1327) [sender=3.2.5]
> >
> > And in ${BP} I cannot see any of those vendor stuff which should be present. Is there some fix for that already pending or its known issue?
>
> That would mean that one of the clones in the SRC_URI is now failing,
> usually by something
> that shouldn't have been changed in the upstream repository that was
> change (a branch
> deleted, directories removed, some other repo now clobbering the dir, etc).
>
> It worked on release, so it was valid then.
>
> If the hash or branch is bad, bitbake should have thrown an error or warning.
>
> I just did a manual clone of that repository, and the result looked ok
> for being able to
> copy that directory into a fully constructed vendor/ tree.
>
> We've changed the format of the src_uri and relocation files in newer
> releases and
> there's an improved script on master-next. If pointing that script at
> the same major
> release of nerdctl works, we could update the recipe to the more
> reliable format,
> as the actual nerdctl target executable would be unchanged.
>

I  just pushed two commits to kirkstone that fixed the nerdctl build
in my fresh clone. Both were backports from master.

I didn't see the same issue with the vendor fetches, so I'm not
sure what is happening with your build on that front.

Bruce

> Bruce
>
> >
> > Thanks and BR,
> >
> > marek
> >
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8297): https://lists.yoctoproject.org/g/meta-virtualization/message/8297
> Mute This Topic: https://lists.yoctoproject.org/mt/101310644/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/leave/6693017/1050810/978058475/xyzzy [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


      parent reply	other threads:[~2023-09-13 13:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAfyv34+oTQaT=9-QGkTdCFSJaC6CS=RB6SF=FQrOUssntoBSA@mail.gmail.com>
2023-09-12  7:26 ` nerdctl broken in kirkstone Belisko Marek
2023-09-12 18:32   ` [meta-virtualization] " Bruce Ashfield
     [not found]   ` <17843A682EC729DC.10919@lists.yoctoproject.org>
2023-09-13 13:45     ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADkTA4MFixZWj64GcwB0E+OKkSVySBC8m96+64qLvHcc212P4A@mail.gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=marek.belisko@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).