meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: joerg.sommer@navimatix.de
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] packagegroup-container: require ipv6 for podman
Date: Wed, 11 Oct 2023 14:55:29 -0400	[thread overview]
Message-ID: <CADkTA4M4km=UJsFgXdPUGrg-dbZQLUcQZF-BQXrZz41CXisKRA@mail.gmail.com> (raw)
In-Reply-To: <0ea13e6963ac5988167735946d6db74673a968bb.1697014988.git.joerg.sommer@navimatix.de>

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

The change looks good, but I normally try and capture a bit of the build
failure in the commit log.

That way anyone searching on that specific error, will match on the commit.

If you can spin a quick v2 with that in the log, I'll get it staged.

Bruce

On Wed, Oct 11, 2023 at 5:03 AM Jörg Sommer via lists.yoctoproject.org
<joerg.sommer=navimatix.de@lists.yoctoproject.org> wrote:

> The recipe *podman* requires *ipv6* in *DISTRO_FEATURES*, which causes the
> build of the whole recipe fail, even if packagegroup-podman is not used.
>
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> ---
>  recipes-core/packagegroups/packagegroup-container.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-core/packagegroups/packagegroup-container.bb
> b/recipes-core/packagegroups/packagegroup-container.bb
> index 8d418e9..8309a08 100644
> --- a/recipes-core/packagegroups/packagegroup-container.bb
> +++ b/recipes-core/packagegroups/packagegroup-container.bb
> @@ -9,7 +9,7 @@ PACKAGES = "\
>      packagegroup-lxc \
>      packagegroup-docker \
>      packagegroup-oci \
> -    ${@bb.utils.contains('DISTRO_FEATURES', 'seccomp', \
> +    ${@bb.utils.contains('DISTRO_FEATURES', 'seccomp ipv6', \
>                           'packagegroup-podman', '', d)} \
>      packagegroup-containerd \
>      "
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8347):
> https://lists.yoctoproject.org/g/meta-virtualization/message/8347
> Mute This Topic: https://lists.yoctoproject.org/mt/101893004/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 3958 bytes --]

      reply	other threads:[~2023-10-11 18:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11  9:03 [meta-virtualization][PATCH] packagegroup-container: require ipv6 for podman Jörg Sommer
2023-10-11 18:55 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADkTA4M4km=UJsFgXdPUGrg-dbZQLUcQZF-BQXrZz41CXisKRA@mail.gmail.com' \
    --to=bruce.ashfield@gmail.com \
    --cc=joerg.sommer@navimatix.de \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).