meta-virtualization.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: meta-virtualization@lists.yoctoproject.org
Cc: Martin Jansa <Martin.Jansa@gmail.com>
Subject: [PATCH] runc-opencontainers: use bfd linker even when gold is selected by ls-is-gold
Date: Wed, 26 Jul 2023 15:45:17 +0200	[thread overview]
Message-ID: <20230726134517.3415106-1-Martin.Jansa@gmail.com> (raw)

* fixes:
  ld: --no-dynamic-linker: unknown option
* you might need to clean the build for updated LDFLAGS to be corectly re-configured

* lld and bfd are fine:

$ ld.gold --help | grep dynamic-linker
  -I PROGRAM, --dynamic-linker PROGRAM
$ ld.bfd --help | grep dynamic-linker
  -I PROGRAM, --dynamic-linker PROGRAM
  --no-dynamic-linker         Produce an executable with no program interpreter header
$ ld.lld --help | grep dynamic-linker
  --dynamic-linker=<value>
  --no-dynamic-linker     Inhibit output of .interp section

* not sure where this came from only place where I see --no-dynamic-linker
  in runc-opencontainers WORKDIR is:
  aarch64-oe-linux/13.1.1/plugin/include/config/aarch64/aarch64-linux.h:   %{static-pie:-Bstatic -pie --no-dynamic-linker -z text} \
  aarch64-oe-linux/13.1.1/plugin/include/aarch64-linux.h:   %{static-pie:-Bstatic -pie --no-dynamic-linker -z text} \

  so my guess is:
  923ae4da Makefile: add support for static PIE

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-containers/runc/runc-opencontainers_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/recipes-containers/runc/runc-opencontainers_git.bb b/recipes-containers/runc/runc-opencontainers_git.bb
index 7757baa..e411859 100644
--- a/recipes-containers/runc/runc-opencontainers_git.bb
+++ b/recipes-containers/runc/runc-opencontainers_git.bb
@@ -8,3 +8,5 @@ SRC_URI = " \
 RUNC_VERSION = "1.1.7"
 
 CVE_PRODUCT = "runc"
+
+LDFLAGS += "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd', '', d)}"
-- 
2.41.0



                 reply	other threads:[~2023-07-26 13:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726134517.3415106-1-Martin.Jansa@gmail.com \
    --to=martin.jansa@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).