From: Randolph Sapp <rs@ti.com>
To: <rs@ti.com>, Denys Dmytriyenko <denis@denix.org>,
<meta-ti@lists.yoctoproject.org>
Subject: Re: [meta-ti] [master/scarthgap][PATCH 1/3] ti-img-rogue-*: add ddk 24.1 recipes for ltsprep
Date: Thu, 2 May 2024 13:38:32 -0500 [thread overview]
Message-ID: <D0ZDLK4PIYPK.2XGBECV3OKLZ9@ti.com> (raw)
In-Reply-To: <17CBBDC7EBB3B94C.12650@lists.yoctoproject.org>
On Thu May 2, 2024 at 12:59 PM CDT, Randolph Sapp via lists.yoctoproject.org wrote:
> On Wed May 1, 2024 at 10:01 PM CDT, Denys Dmytriyenko wrote:
> > Reformatted to be a diff against the previous version to spot the actual
> > changes and spot any issues. See below.
> >
> >
> > On Wed, May 01, 2024 at 08:26:19PM -0400, Denys Dmytriyenko wrote:
> > > From: Randolph Sapp <rs@ti.com>
> > >
> > > Add these recipes but lock them behind ltsprep tags because they require
> > > device tree changes that does not work on the current default kernel for
> > > this layer.
> > >
> > > Signed-off-by: Randolph Sapp <rs@ti.com>
> > > Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> > > ---
> > > ....6512818.bb => ti-img-rogue-driver_24.1.6554834.bb} | 4 +++-
> > > ....6512818.bb => ti-img-rogue-umlibs_24.1.6554834.bb} | 10 +++++++---
> > > 2 files changed, 10 insertions(+), 4 deletions(-)
> > > copy meta-ti-bsp/recipes-bsp/powervr-drivers/{ti-img-rogue-driver_23.3.6512818.bb => ti-img-rogue-driver_24.1.6554834.bb} (94%)
> > > copy meta-ti-bsp/recipes-graphics/powervr-umlibs/{ti-img-rogue-umlibs_23.3.6512818.bb => ti-img-rogue-umlibs_24.1.6554834.bb} (94%)
> > >
> > > diff --git a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_24.1.6554834.bb
> > > similarity index 94%
> > > copy from meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> > > copy to meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_24.1.6554834.bb
> > > index 02ec9fe9..a1b76d27 100644
> > > --- a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> > > +++ b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_24.1.6554834.bb
> > > @@ -3,6 +3,8 @@ HOMEPAGE = "http://git.ti.com/graphics/ti-img-rogue-driver"
> > > LICENSE = "MIT | GPL-2.0-only"
> > > LIC_FILES_CHKSUM = "file://README;beginline=14;endline=19;md5=0403c7dea01a2b8232261e805325fac2"
> > >
> > > +DEFAULT_PREFERENCE = "-1"
> > > +
> > > inherit module
> > >
> > > PROVIDES = "virtual/gpudriver"
> > > @@ -22,7 +24,7 @@ SRC_URI = "git://git.ti.com/git/graphics/ti-img-rogue-driver.git;protocol=https;
> > >
> > > S = "${WORKDIR}/git"
> > >
> > > -SRCREV = "2f409b4dd2540e896b54bff02219d4fc51129b81"
> > > +SRCREV = "e2dfdfee991dadc18175f27fe9e8676e910a2f8d"
> > >
> > > TARGET_PRODUCT:j721e = "j721e_linux"
> > > TARGET_PRODUCT:j721s2 = "j721s2_linux"
> > > diff --git a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.3.6512818.bb b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_24.1.6554834.bb
> > > similarity index 94%
> > > copy from meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.3.6512818.bb
> > > copy to meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_24.1.6554834.bb
> > > index a0a9a295..df426d1a 100644
> > > --- a/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_23.3.6512818.bb
> > > +++ b/meta-ti-bsp/recipes-graphics/powervr-umlibs/ti-img-rogue-umlibs_24.1.6554834.bb
> > > @@ -3,6 +3,8 @@ HOMEPAGE = "http://git.ti.com/graphics/ti-img-rogue-umlibs"
> > > LICENSE = "TI-TFL"
> > > LIC_FILES_CHKSUM = "file://${WORKDIR}/git/LICENSE;md5=7232b98c1c58f99e3baa03de5207e76f"
> > >
> > > +DEFAULT_PREFERENCE = "-1"
> > > +
> > > inherit bin_package
> > >
> > > INHIBIT_DEFAULT_DEPS = ""
> > > @@ -14,7 +16,7 @@ PR = "r3"
> > >
> > > BRANCH = "linuxws/scarthgap/k6.6/${PV}"
> > > SRC_URI = "git://git.ti.com/git/graphics/ti-img-rogue-umlibs.git;protocol=https;branch=${BRANCH}"
> > > -SRCREV = "0b9e64254269be2fa95c4f3e1dd925d6e4d58199"
> > > +SRCREV = "e473234158c736248cf71a60080b7faf76fca561"
> > > S = "${WORKDIR}/git/targetfs/${TARGET_PRODUCT}/${PVR_WS}/${PVR_BUILD}"
> > >
> > > TARGET_PRODUCT:j721e = "j721e_linux"
> > > @@ -109,7 +111,7 @@ python __anonymous() {
> > > mlprefix = d.getVar("MLPREFIX")
> > > pkgs = " " + " ".join(mlprefix + x + suffix for x in p[1:])
> > > d.setVar("DEBIAN_NOAUTONAME:" + fullp, "1")
> > > - d.setVar("INSANE_SKIP:" + fullp, "dev-so")
> > > + d.setVar("INSANE_SKIP:" + fullp, "dev-so ldflags")
> > > d.appendVar("RRECOMMENDS:" + fullp, " ${MLPREFIX}ti-img-rogue-umlibs" + suffix)
> > > }
> > >
> > > @@ -133,6 +135,8 @@ DEBIAN_NOAUTONAME:libopencl-rogue-tools = "1"
> > > # optional tools and tests
> > > FILES:${PN}-tools = "${bindir}/"
> > > RDEPENDS:${PN}-tools = "python3-core ${PN}"
> >
> > ^^^
> >
> > > +INSANE_SKIP:${PN}-tools = "ldflags"
> > > +RDEPENDS:${PN}-tools = "libdrm"
> >
> > This overrides/replaces earlier RDEPENDS
>
> Good catch.
>
> > >
> > > # required firmware
> > > FILES:${PN}-firmware = "${base_libdir}/firmware/*"
> > > @@ -142,4 +146,4 @@ RRECOMMENDS:${PN} += " \
> > > ${PN}-tools \
> > > "
> > >
> > > -INSANE_SKIP:${PN} += "already-stripped dev-so"
> > > +INSANE_SKIP:${PN} += "already-stripped dev-so ldflags"
> >
> > Why is ldflags QA check needs to be skipped now?
>
> QA was tripping up on new issues. We are now using the Yocto toolchains with
> some other tricks to produce these binaries. This provides enough metadata to
> trigger extra stages in the qa checks. One of these checks an internal hash
> variable that is not currently being set by the IMG build system, so it will
> fail.
The explicit message was:
File [binary] in package ti-img-rogue-umlibs-tools doesn't have GNU_HASH (didn't pass LDFLAGS?)
https://docs.yoctoproject.org/ref-manual/qa-checks.html#qa-check-ldflags
We can't exactly pass all the LD flags as written when building outside of
Yocto.
next prev parent reply other threads:[~2024-05-02 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17CB8455266768D4.4497@lists.yoctoproject.org>
2024-05-02 3:01 ` [meta-ti] [master/scarthgap][PATCH 1/3] ti-img-rogue-*: add ddk 24.1 recipes for ltsprep Denys Dmytriyenko
2024-05-02 17:59 ` Randolph Sapp
[not found] ` <17CBBDC7EBB3B94C.12650@lists.yoctoproject.org>
2024-05-02 18:38 ` Randolph Sapp [this message]
2024-04-30 21:38 [meta-ti][master/scarthgap][PATCH 0/3] GFX driver and mesa update rs
2024-04-30 21:38 ` [meta-ti][master/scarthgap][PATCH 1/3] ti-img-rogue-*: add ddk 24.1 recipes for ltsprep rs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0ZDLK4PIYPK.2XGBECV3OKLZ9@ti.com \
--to=rs@ti.com \
--cc=denis@denix.org \
--cc=meta-ti@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).