meta-ti.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Judith Mendez <jm@ti.com>
To: Praneeth Bajjuri <praneeth@ti.com>, <meta-ti@lists.yoctoproject.org>
Cc: Ryan Eatmon <reatmon@ti.com>, Jai Luthra <j-luthra@ti.com>
Subject: Re: [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix
Date: Wed, 8 Nov 2023 11:03:19 -0600	[thread overview]
Message-ID: <25354ef9-9809-4b4b-a7fd-e79fdfc92aa2@ti.com> (raw)
In-Reply-To: <20231108160437.15536-1-praneeth@ti.com>

Hi all,

On 11/8/23 10:04 AM, Praneeth Bajjuri wrote:
> commit f5851386 ("conf: machine: am62*: Pick common overlays by prefix")
> picks common HDMI and CSI overlays for am62 platform variants.
> 
> Adding capability to extend the same prefix for common overlays for applicable
> am62 platforms in more generic way to include new mcan overlays added [1]
> 
> [1]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?&id=3b01c392627f
> 
> given the differences in SK-AM62-LP containing  B2B HDMI Samtec connector,
> just added the kernel prefix to pick common mcan overlay.
> 
> for am62pxx: It has 4 MCANs vs all other am62xx devices have 3 MCANs,
> hence keeping this prefix seperate for am62pxx to pick right overlay.
> 

Looks good to me.

Reviewed-by: Judith Mendez <jm@ti.com>

> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com>
> ---
> v2: updated am62xxsip conf and updated for am62pxx to pick different
> mcan overlay
> 
>   meta-ti-bsp/conf/machine/am62axx-evm.conf   | 3 +--
>   meta-ti-bsp/conf/machine/am62xx-evm.conf    | 3 +--
>   meta-ti-bsp/conf/machine/am62xx-lp-evm.conf | 1 +
>   meta-ti-bsp/conf/machine/am62xxsip-evm.conf | 4 ++--
>   4 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/am62axx-evm.conf b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> index ef60e9d1..22f61401 100644
> --- a/meta-ti-bsp/conf/machine/am62axx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62axx-evm.conf
> @@ -6,8 +6,7 @@ require conf/machine/include/am62axx.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am62a7 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>       ti/k3-fpdlink \
>   "
>   
> diff --git a/meta-ti-bsp/conf/machine/am62xx-evm.conf b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> index b60ba156..fadbc6f4 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-evm.conf
> @@ -7,8 +7,7 @@ require conf/machine/include/ti-extras.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
>   "
>   
>   KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> index 0d2f89ca..afa5e061 100644
> --- a/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xx-lp-evm.conf
> @@ -8,6 +8,7 @@ KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am62-lp \
>       ti/k3-am625-sk \
>       ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk-mcan \
>   "
>   
>   KERNEL_DEVICETREE = " \
> diff --git a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> index b3bda44a..cae58afe 100644
> --- a/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> +++ b/meta-ti-bsp/conf/machine/am62xxsip-evm.conf
> @@ -6,8 +6,8 @@ require conf/machine/include/am62xx.inc
>   
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-am625 \
> -    ti/k3-am62x-sk-csi2 \
> -    ti/k3-am62x-sk-hdmi \
> +    ti/k3-am62x-sk \
> +
>   "
>   
>   KERNEL_DEVICETREE = " \



      parent reply	other threads:[~2023-11-08 17:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 16:04 [kirkstone PATCH v2] conf: machine: am62*: extend picking common overlays by prefix Praneeth Bajjuri
2023-11-08 16:12 ` Jai Luthra
2023-11-08 16:43 ` Judith Mendez
2023-11-08 16:59   ` Ryan Eatmon
2023-11-08 17:01     ` Judith Mendez
2023-11-08 17:03 ` Judith Mendez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25354ef9-9809-4b4b-a7fd-e79fdfc92aa2@ti.com \
    --to=jm@ti.com \
    --cc=j-luthra@ti.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=praneeth@ti.com \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).