From: Ryan Eatmon <reatmon@ti.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: Praneeth Bajjuri <praneeth@ti.com>,
Denys Dmytriyenko <denys@konsulko.com>,
<meta-ti@lists.yoctoproject.org>
Subject: Re: [meta-ti][master][PATCH] gdbc6x: Fix kernel module to work on 6.6+
Date: Thu, 8 Feb 2024 12:50:14 -0600 [thread overview]
Message-ID: <189a5279-b932-45d5-9ea4-d8e6f9d917aa@ti.com> (raw)
In-Reply-To: <20240208181148.GH15614@denix.org>
On 2/8/2024 12:11 PM, Denys Dmytriyenko wrote:
> On Thu, Feb 08, 2024 at 11:55:25AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
>> The "upstream" is not maintained, but this is an easy patch to get this
>> working again. Still need to watch this for big breakages and rethink
>> supporting this recipe at that time.
>>
>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> ---
>> .../0002-Support-Linux-kernels-v6.6.patch | 31 +++++++++++++++++++
>> .../gdbc6x/gdbserverproxy-module-drv_git.bb | 5 ++-
>> 2 files changed, 35 insertions(+), 1 deletion(-)
>> create mode 100644 meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv/0002-Support-Linux-kernels-v6.6.patch
>>
>> diff --git a/meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv/0002-Support-Linux-kernels-v6.6.patch b/meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv/0002-Support-Linux-kernels-v6.6.patch
>> new file mode 100644
>> index 00000000..dab4e26b
>> --- /dev/null
>> +++ b/meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv/0002-Support-Linux-kernels-v6.6.patch
>> @@ -0,0 +1,31 @@
>> +From: Ryan Eatmon <reatmon@ti.com>
>> +Date: Wed, 08 Feb 2024 10:43:00 -0500
>> +Subject: [PATCH] Support Linux kernels v6.6+
>> +
>> +gdb_write arg changed from int to unsigned int
>> +
>> +Upstream-Status: Pending
>
> FWIW, there's also Inactive-Upstream status, if needed:
> https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status
So noted. I'll update the two patches with that.
>> +Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> +---
>> + kernel_module/gdbproxy-mod/gdbserverproxy.c | 6 +++++-
>> + 1 file changed, 5 insertions(+), 1 deletion(-)
>> +
>> +diff --git a/kernel_module/gdbproxy-mod/gdbserverproxy.c b/kernel_module/gdbproxy-mod/gdbserverproxy.c
>> +index 418b6db..4b1c676 100644
>> +--- a/kernel_module/gdbproxy-mod/gdbserverproxy.c
>> ++++ b/kernel_module/gdbproxy-mod/gdbserverproxy.c
>> +@@ -496,8 +496,13 @@ static void gdb_close(struct tty_struct *tty, struct file *filp)
>> + *
>> + *
>> + */
>> ++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(6,6,0))
>> ++static int gdb_write(struct tty_struct *tty,
>> ++ const unsigned char *buf, unsigned int count)
>> ++#else
>> + static int gdb_write(struct tty_struct *tty,
>> + const unsigned char *buf, int count)
>> ++#endif
>> + {
>> + struct dsp_session *dsp = tty->driver_data;
>> + int ret = 0;
>> diff --git a/meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb b/meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb
>> index 60492f81..b68c4463 100644
>> --- a/meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb
>> +++ b/meta-ti-extras/recipes-devtools/gdbc6x/gdbserverproxy-module-drv_git.bb
>> @@ -7,7 +7,10 @@ MACHINE_KERNEL_PR:append = "b"
>> PR = "${MACHINE_KERNEL_PR}"
>> PV:append = "+git${SRCPV}"
>>
>> -SRC_URI:append = " file://0001-Support-Linux-kernels-v5.15.patch;patchdir=../.."
>> +SRC_URI:append = "\
>> + file://0001-Support-Linux-kernels-v5.15.patch;patchdir=../.. \
>> + file://0002-Support-Linux-kernels-v6.6.patch;patchdir=../.. \
>> +"
>>
>> S = "${WORKDIR}/git/kernel_module/gdbproxy-mod"
>>
>> --
>> 2.17.1
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
prev parent reply other threads:[~2024-02-08 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 17:55 [meta-ti][master][PATCH] gdbc6x: Fix kernel module to work on 6.6+ Ryan Eatmon
2024-02-08 18:11 ` Denys Dmytriyenko
2024-02-08 18:50 ` Ryan Eatmon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=189a5279-b932-45d5-9ea4-d8e6f9d917aa@ti.com \
--to=reatmon@ti.com \
--cc=denis@denix.org \
--cc=denys@konsulko.com \
--cc=meta-ti@lists.yoctoproject.org \
--cc=praneeth@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).