From: alfredomantillajobs@gmail.com
To: meta-freescale@lists.yoctoproject.org
Subject: PCIe kernel crash using fsl-community-bsp-platform kirkstone on imx8qm-mek
Date: Thu, 20 Oct 2022 01:21:22 -0700 [thread overview]
Message-ID: <lOPg.1666254082928962124.as7G@lists.yoctoproject.org> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 284 bytes --]
Hi,
Any read to the PCI will cause a kernel crash/hang just building for the machine out of the box
It looks like a return code was removed when resolving a merge conflict in the kernel (linux-fslc-imx/5.15.67+gitAUTOINC+845d53f13a-r0f)
The patch I include solves the issue
[-- Attachment #1.2: Type: text/html, Size: 308 bytes --]
[-- Attachment #2: 0001-PCI-imx6-Fix-crash-caused-by-disabling-clocks-when-t.patch --]
[-- Type: application/octet-stream, Size: 1020 bytes --]
From bf45edbd674809f3c5851b49f569af676b8e9897 Mon Sep 17 00:00:00 2001
From: Alfredo Mantilla <alfredo.mantilla-aparicio@ttcontrol.com>
Date: Thu, 20 Oct 2022 10:15:43 +0200
Subject: [PATCH] PCI: imx6: Fix crash caused by disabling clocks when they
should not
---
drivers/pci/controller/dwc/pci-imx6.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index e3fa0aae0cbf..eff370597453 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -812,6 +812,7 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie)
default:
break;
}
+ return ret;
err_pciex2_per:
clk_disable_unprepare(imx6_pcie->pcie_phy_pclk);
@@ -1370,6 +1371,7 @@ static void imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6_pcie)
/* Wait for 100ms after PERST# deassertion (PCIe r5.0, 6.6.1) */
msleep(100);
}
+ return;
err_ref_clk:
clk_disable_unprepare(imx6_pcie->pcie);
--
2.31.1
next reply other threads:[~2022-10-20 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 8:21 alfredomantillajobs [this message]
2022-10-20 11:27 ` [meta-freescale] PCIe kernel crash using fsl-community-bsp-platform kirkstone on imx8qm-mek Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lOPg.1666254082928962124.as7G@lists.yoctoproject.org \
--to=alfredomantillajobs@gmail.com \
--cc=meta-freescale@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).