From: "Fabio Estevam" <festevam@gmail.com>
To: Wouter Vanhauwaert <w.vanhauwaert@televic.com>
Cc: meta-freescale@lists.yoctoproject.org
Subject: Re: [meta-freescale] Adding LCD display (none lvds) in Linux 5.4 fslc?
Date: Mon, 17 Aug 2020 17:40:08 -0300 [thread overview]
Message-ID: <CAOMZO5CsWDm9F2rfDooj=TTaeTa=Nv37aCZLo+hrz73gu=fcug@mail.gmail.com> (raw)
In-Reply-To: <19396.1597690754713089020@lists.yoctoproject.org>
Hi Wouter,
On Mon, Aug 17, 2020 at 3:59 PM Wouter Vanhauwaert
<w.vanhauwaert@televic.com> wrote:
>
> Sorry, but I think that's not correct...
Yes, when I looked at the commit you referred to I thought initially
that it only added drivers/video/fbdev/mxsfb.c, which is the eLCDIF
controller. In fact, it adds more things other than the mxsfb driver
and it also handles the IPU driver.
> Indeed, you can use fsl,imx-parallel-display, but then you're using the opensource/drm mainline way of addressing the ipu, and not the freescale proprietary way.
Correct.
> fbdev/mxc/ldb.c is still providing the freescale proprietary way of configuring a mxcfb device
> fbdev/mxc/mxc_lcdif.c is also using the imx6q/dl ipu for it's parallel lcd display, only it is gone since kernel 4.9-imx, which is strange as even the imx6qdl-sabresd.dtsi in the 5.4-2.0.x-imx branch is referring to it..
> The way it is now, nothing is handling the compatible "fsl,lcd" in the whole 4.9-imx or 5.4-imx kernels, which is wrong according to me. I think it is just forgotten in a previous merge...
Yes, I agree.
> That would mean that commit https://github.com/Freescale/linux-fslc/commit/afcde9250592b07f165e2f66217726e26ac54e7c was incomplete.
> As a test, I just put back the mxc_lcdif.c, and now my display is working perfectly again with configured devicetree:
>
> lcd@0 {
> compatible = "fsl,lcd";
> ipu_id = <0>;
> disp_id = <0>;
> default_ifmt = "RGB24";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ipu1>;
> status = "okay";
> };
>
> mxcfb1: fb@0 {
> compatible = "fsl,mxc_sdc_fb";
> disp_dev = "lcd";
> interface_pix_fmt = "RGB24";
> mode_str ="CLAA-WVGA";
> default_bpp = <16>;
> int_clk = <0>;
> late_init = <0>;
> status = "disabled";
> };
>
> If you think I am correct, I can create a pullrequest...
It looks correct.
Sorry for the confusion, I thought your goal was to use the "mainline"
way to drive a parallel panel on mx6. Now I understand that you want
to use the "NXP way".
prev parent reply other threads:[~2020-08-17 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 10:28 Adding LCD display (none lvds) in Linux 5.4 fslc? Wouter Vanhauwaert
2020-08-13 10:39 ` [meta-freescale] " Philippe Schenker
2020-08-13 12:28 ` Wouter Vanhauwaert
2020-08-13 13:49 ` [meta-freescale] " Christian Betz
[not found] ` <162AD810805EBE6C.3117@lists.yoctoproject.org>
2020-08-13 14:08 ` Christian Betz
2020-08-14 9:17 ` Wouter Vanhauwaert
2020-08-17 10:16 ` Wouter Vanhauwaert
2020-08-17 18:13 ` [meta-freescale] " Fabio Estevam
2020-08-17 18:59 ` Wouter Vanhauwaert
2020-08-17 20:40 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CsWDm9F2rfDooj=TTaeTa=Nv37aCZLo+hrz73gu=fcug@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=meta-freescale@lists.yoctoproject.org \
--cc=w.vanhauwaert@televic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).