From: Ryan Eatmon <reatmon@ti.com>
To: Andrew Davis <afd@ti.com>, Denys Dmytriyenko <denys@konsulko.com>,
<meta-arago@lists.yoctoproject.org>
Subject: Re: [meta-arago][master/kirkstone][PATCH 1/2] initscript-telnetd: Remove this package
Date: Tue, 24 Oct 2023 15:03:13 -0500 [thread overview]
Message-ID: <f967e663-f079-4d2f-880e-db91b4a14778@ti.com> (raw)
In-Reply-To: <20231016211840.23815-1-afd@ti.com>
Someone brought up a good point on another patch. Even though we
configure Arago to be systemd BY DEFAULT. The user can always choose
switch over to sysvinit. So we should probably leave this in until we
decide not not support telnet anymore.
On 10/16/2023 4:18 PM, Andrew Davis wrote:
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> .../initscript-telnetd/initscript-telnetd.bb | 18 ---------
> .../initscript-telnetd/telnetd | 40 -------------------
> .../packagegroups/packagegroup-arago-base.bb | 1 -
> 3 files changed, 59 deletions(-)
> delete mode 100644 meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
> delete mode 100644 meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
>
> diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb b/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
> deleted file mode 100644
> index e492119b..00000000
> --- a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd.bb
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -DESCRIPTION = "Initscripts for telnetd"
> -LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://telnetd;beginline=2;endline=18;md5=d134d0d385c53f9201a270fef8448f29"
> -PR ="r1"
> -
> -SRC_URI = "file://telnetd"
> -
> -S = "${WORKDIR}"
> -
> -INITSCRIPT_NAME = "telnetd"
> -INITSCRIPT_PARAMS = "defaults 10"
> -
> -inherit update-rc.d
> -
> -do_install () {
> - install -d ${D}${sysconfdir}/init.d/
> - install -c -m 755 ${S}/telnetd ${D}${sysconfdir}/init.d/telnetd
> -}
> diff --git a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd b/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
> deleted file mode 100644
> index a99f23ef..00000000
> --- a/meta-arago-distro/recipes-connectivity/initscript-telnetd/initscript-telnetd/telnetd
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -#! /bin/sh
> -#Permission is hereby granted, free of charge, to any person obtaining a copy
> -#of this software and associated documentation files (the "Software"), to deal
> -#in the Software without restriction, including without limitation the rights
> -#to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> -#copies of the Software, and to permit persons to whom the Software is
> -#furnished to do so, subject to the following conditions:
> -#
> -#The above copyright notice and this permission notice shall be included in
> -#all copies or substantial portions of the Software.
> -#
> -#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> -#IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> -#FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> -#AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> -#LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> -#OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> -#THE SOFTWARE.
> -
> -telnetd=/usr/sbin/telnetd
> -
> -test -x "$telnetd" || exit 0
> -
> -case "$1" in
> - start)
> - echo -n "Starting telnet daemon"
> - start-stop-daemon --start --quiet --exec $telnetd
> - echo "."
> - ;;
> - stop)
> - echo -n "Stopping telnet daemon"
> - start-stop-daemon --stop --quiet --exec $telnetd
> - echo "."
> - ;;
> - *)
> - echo "Usage: /etc/init.d/telnetd {start|stop}"
> - exit 1
> -esac
> -
> -exit 0
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> index 1f63a7d0..5e528846 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb
> @@ -16,7 +16,6 @@ ARAGO_BASE = "\
> mtd-utils \
> mtd-utils-ubifs \
> curl \
> - initscript-telnetd \
> ethtool \
> thermal-init \
> bash \
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
prev parent reply other threads:[~2023-10-24 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 21:18 [meta-arago][master/kirkstone][PATCH 1/2] initscript-telnetd: Remove this package Andrew Davis
2023-10-16 21:18 ` [meta-arago][master/kirkstone][PATCH 2/2] shadow-securetty: Do not allow root login over telnet Andrew Davis
2023-10-17 9:22 ` [EXTERNAL] " Chirag Shilwant
2023-10-17 17:28 ` Denys Dmytriyenko
2023-10-19 22:02 ` Ryan Eatmon
2023-10-24 20:03 ` Ryan Eatmon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f967e663-f079-4d2f-880e-db91b4a14778@ti.com \
--to=reatmon@ti.com \
--cc=afd@ti.com \
--cc=denys@konsulko.com \
--cc=meta-arago@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).