meta-arago.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Randolph Sapp <rs@ti.com>
To: Darren Etheridge <detheridge@ti.com>,
	<meta-arago@lists.yoctoproject.org>, <reatmon@ti.com>,
	<denys@konsulko.com>
Subject: Re: [meta-arago][kirkstone][PATCH 0/4] cleanup old/add new chromium
Date: Mon, 5 Feb 2024 16:16:51 -0600	[thread overview]
Message-ID: <d4f10275-5b3b-41b1-8ba3-10aed3ba8d2d@ti.com> (raw)
In-Reply-To: <20240205191643.19614-1-detheridge@ti.com>

On 2/5/24 13:16, Darren Etheridge wrote:
> Patch series to add IMG PowerVR GPU accelerated Chromium support into
> Kirkstone.
> 
> Patch 1 and 4 clean up some of the old Chromium cruft that was left in
> the kirkstone branch that I can't imagine can possibly be useful now.
> 
> Then patch 2 and 3 add in a new dynamic layer to provide GPU support to
> Chromium by allowing the PowerVR libraries to be used from within the
> Chromium sandbox.   Also apply an upstream Chromium patch to stop
> Chromium from segfaulting immediately on startup if no input devices are
> detected.
> The dynamic layer will append chromium-ozone-wayland to the
> IMAGE_INSTALL for tisdk-default-image if the meta-browser layer is
> detected.
> 
> Currently we need to pin the meta-browser layer to chromium v111 as there are
> problems with the GPU integration in newer versions.  This pinning will
> be taken care of as part of oe-layersetup once we decide if it becomes a
> new "chromium" configuration, or if we add these layers into the normal
> kirkstone configurations.  Downside is build time increases
> considerably and image size increases.
> 
> All of this working depends on IMG PowerVR DDK23.3 being available in
> meta-ti - Randolph sent these patches for review last week.
> 
> Darren Etheridge (4):
>    meta-arago: distro: chromium: remove old dynamic layer
>    meta-arago: distro: add a bbapend to patch the chromium browser
>    meta-arago: images: update tisdk-default-image to include chromium
>    meta-arago: tisdk-default-image: remove old chromium logic
> 
>   meta-arago-distro/conf/layer.conf             |  4 +-
>   .../chromium-75.0.3770.80-SIOCGSTAMP.patch    | 15 ----
>   .../chromium-ozone-wayland/pulse.patch        | 47 ------------
>   .../chromium-ozone-wayland_%.bbappend         |  8 --
>   ...omium-ozone-wayland_111.0.5563.64.bbappend |  8 ++
>   ...dbox-allow-access-to-PowerVR-GPU-fro.patch | 74 +++++++++++++++++++
>   ...-chromium-32307795-fix-nullprt-deref.patch | 52 +++++++++++++
>   .../images/tisdk-default-image.bbappend       |  3 +
>   .../images/tisdk-default-image.bb             | 10 ---
>   9 files changed, 139 insertions(+), 82 deletions(-)
>   delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland/chromium-75.0.3770.80-SIOCGSTAMP.patch
>   delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland/pulse.patch
>   delete mode 100644 meta-arago-distro/dynamic-layers/browser-layer/recipes-browser/chromium/chromium-ozone-wayland_%.bbappend
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64.bbappend
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64/0001-chromium-gpu-sandbox-allow-access-to-PowerVR-GPU-fro.patch
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-browser/chromium/chromium-ozone-wayland_111.0.5563.64/0002-upstream-chromium-32307795-fix-nullprt-deref.patch
>   create mode 100644 meta-arago-distro/dynamic-layers/chromium-browser-layer/recipes-core/images/tisdk-default-image.bbappend
> 

This looks fine and can be applied to master as well.

Reviewed-by: Randolph Sapp <rs@ti.com>


       reply	other threads:[~2024-02-05 22:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240205191643.19614-1-detheridge@ti.com>
2024-02-05 22:16 ` Randolph Sapp [this message]
2024-02-06 17:58 [meta-arago][kirkstone][PATCH 0/4] cleanup old/add new chromium detheridge
2024-02-06 18:01 ` Randolph Sapp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4f10275-5b3b-41b1-8ba3-10aed3ba8d2d@ti.com \
    --to=rs@ti.com \
    --cc=denys@konsulko.com \
    --cc=detheridge@ti.com \
    --cc=meta-arago@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).