From: Chirag Shilwant <c-shilwant@ti.com>
To: Ryan Eatmon <reatmon@ti.com>, Denys Dmytriyenko <denis@denix.org>
Cc: <meta-arago@lists.yoctoproject.org>, Gyan Gupta <g-gupta@ti.com>
Subject: Re: [EXTERNAL] [meta-arago][scarthgap][PATCH] meta-arago-extras: packagegroups: Fix QA Issue
Date: Wed, 17 Apr 2024 11:35:28 +0530 [thread overview]
Message-ID: <74265976-61a1-4e63-9ade-3ba5ae759f9e@ti.com> (raw)
In-Reply-To: <04ade28e-de1a-43d4-afce-3c335bec8d97@ti.com>
On 17/04/24 00:57, Ryan Eatmon wrote:
>
>
> On 4/16/2024 10:09 AM, Denys Dmytriyenko wrote:
>> On Tue, Apr 16, 2024 at 12:07:33PM +0530, Chirag Shilwant wrote:
>>> Just a head's up,
>>>
>>> Note that the reason to send the patch on scarthgap only is to
>>> ensure that
>>> we don't break compatibility with all the older releases we have
>>> listed in
>>> LAYERSERIES_COMPAT in arago master [1] as "inherit_defer" was added
>>> in bitbake's latest versions
>>> and someone using arago master:HEAD & bitbake 2.0 for
>>> |kirkstone|based buildwill face build issues
>>> related to inherit_defer.
>>>
>>> [1]:
>>> https://git.ti.com/cgit/arago-project/meta-arago/tree/meta-arago-distro/conf/layer.conf#n11
>>
>> Ah, thanks for the clarification, I didn't see this reply and just
>> commented
>> about master for the original patch.
>>
>> That said, this raises the question whether master should get its
>> compatibility updated to not be compatible with kirkstone any more.
>
> Probably. I'll send the needed changes.
Great, Thanks Ryan!
>
>
>>
>>> On 16/04/24 11:53, Chirag Shilwant via lists.yoctoproject.org wrote:
>>>> - Since packagegroup. bbclass is using inherit_defer in oe-core,
>>>> some classes are now appearing after nativesdk resulting in
>>>> following QA errors. ``` QA Issue:
>>>> nativesdk-packagegroup-arago-tisdk-host: native/nativesdk class is
>>>> not inherited
>>>> ZjQcmQRYFpfptBannerStart
>>>> This message was sent from outside of Texas Instruments.
>>>> Do not click links or open attachments unless you recognize the
>>>> source of this email and know the content is safe. If you wish to
>>>> report this message to IT Security, please forward the message as
>>>> an attachment to phishing@list.ti.com
>>>> ZjQcmQRYFpfptBannerEnd
>>>> - Since packagegroup.bbclass is using inherit_defer in oe-core,
>>>> some classes are
>>>> now appearing after nativesdk resulting in following QA errors.
>>>>
>>>> ```
>>>> QA Issue: nativesdk-packagegroup-arago-tisdk-host:
>>>> native/nativesdk class is not inherited last, this can result in
>>>> unexpected behaviour. Classes inherited after native/nativesdk:
>>>> allarch.bbclass [native-last]
>>>> QA Issue: nativesdk-packagegroup-arago-qte-toolchain-host:
>>>> native/nativesdk class is not inherited last, this can result in
>>>> unexpected behaviour. Classes inherited after native/nativesdk:
>>>> allarch.bbclass [native-last]
>>>>
>>>> ```
>>>>
>>>> - To fix this issue, use inherit_defer that was added in bitbake
>>>> recently [1].
>>>>
>>>> [1]:https://urldefense.com/v3/__https://github.com/openembedded/bitbake/commit/5c2e840eafeba1f0f754c226b87bfb674f7bea29__;!!G3vK!XlpMRQ0dPBA3Up6LIrRyo2n5gEKzSXWswqZ4IyG9eG84QRRtFjpT5b7c1euiHHKkt_TsDxD6JXb0myK8YtlEGLw0V9We6idkBab_$
>>>>
>>>>
>>>> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
>>>> ---
>>>> .../nativesdk-packagegroup-arago-qte-toolchain-host.bb | 3 ++-
>>>> .../packagegroups/nativesdk-packagegroup-arago-tisdk-host.bb | 3 ++-
>>>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git
>>>> a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-qte-toolchain-host.bb
>>>> b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-qte-toolchain-host.bb
>>>>
>>>> index 4d2a98ad..23c45abf 100644
>>>> ---
>>>> a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-qte-toolchain-host.bb
>>>> +++
>>>> b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-qte-toolchain-host.bb
>>>> @@ -2,7 +2,8 @@ DESCRIPTION = "Host packages for Qt Embedded SDK"
>>>> PR = "r10"
>>>> LICENSE = "MIT"
>>>> -inherit packagegroup nativesdk
>>>> +inherit packagegroup
>>>> +inherit_defer nativesdk
>>>> RDEPENDS:${PN} = "\
>>>> nativesdk-packagegroup-arago-tisdk-host \
>>>> diff --git
>>>> a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-tisdk-host.bb
>>>> b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-tisdk-host.bb
>>>>
>>>> index 7e77d12f..92a80b6b 100644
>>>> ---
>>>> a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-tisdk-host.bb
>>>> +++
>>>> b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-tisdk-host.bb
>>>> @@ -2,7 +2,8 @@ SUMMARY = "Host packages for a standalone Arago SDK
>>>> with TI tools"
>>>> PR = "r2"
>>>> LICENSE = "MIT"
>>>> -inherit packagegroup nativesdk
>>>> +inherit packagegroup
>>>> +inherit_defer nativesdk
>>>> PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
>>>> --
>>>> 2.34.1
>
prev parent reply other threads:[~2024-04-17 6:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17C6AE87F40E31DD.13290@lists.yoctoproject.org>
2024-04-16 6:37 ` [EXTERNAL] [meta-arago][scarthgap][PATCH] meta-arago-extras: packagegroups: Fix QA Issue Chirag Shilwant
2024-04-16 15:09 ` Denys Dmytriyenko
2024-04-16 19:27 ` Ryan Eatmon
2024-04-17 6:05 ` Chirag Shilwant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74265976-61a1-4e63-9ade-3ba5ae759f9e@ti.com \
--to=c-shilwant@ti.com \
--cc=denis@denix.org \
--cc=g-gupta@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).