From: Ryan Eatmon <reatmon@ti.com>
To: Denys Dmytriyenko <denis@denix.org>
Cc: <sinthu.raja@mistralsolutions.com>, <denys@konsulko.com>,
<praneeth@ti.com>, <meta-arago@lists.yoctoproject.org>,
<u-kumar1@ti.com>, Sinthu Raja <sinthu.raja@ti.com>
Subject: Re: [meta-arago][krikstone][PATCH RFC 2/4] gst-plugins-ti: Enable network task flag for do_configure
Date: Wed, 6 Dec 2023 18:57:57 -0600 [thread overview]
Message-ID: <658f7403-cb11-4a9f-a85c-7c705295edd0@ti.com> (raw)
In-Reply-To: <20231206223824.GC11745@denix.org>
On 12/6/2023 4:38 PM, Denys Dmytriyenko wrote:
> On Wed, Dec 06, 2023 at 09:33:31AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
>>
>>
>> On 12/6/2023 8:36 AM, Sinthu Raja M via lists.yoctoproject.org wrote:
>>> From: Sinthu Raja <sinthu.raja@ti.com>
>>>
>>> The Ducati and VPE gst plugins requires network during the do_configure task
>>> so, enable the network task flag for the same.
>>
>> Why does it require network? Can you elaborate a little more?
>
> Because sources in git didn't have common gstreamer-specific autotools
> files, scripts and supporting stuff, which were pulled and setup as a
> "common" git submodule from here:
> git://anongit.freedesktop.org/gstreamer/common
> https://cgit.freedesktop.org/gstreamer/common/
>
> That is done by autogen.sh in do_configure():
> https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ti.inc
> https://git.ti.com/cgit/glsdk/gst-plugin-ducati/tree/autogen.sh
>
> That's also been the case for git versions of the upstream gstreamer and
> plugins years ago. So, autogen.sh had to be called after do_unpack() and
> before do_configure(), but the former is a python function.
>
> Released versions of gstreamer and plugins never had this issue, as they
> come with all required pieces already packaged in a tarball.
>
> All git-versioned recipes for gstreamer and plugins were removed from
> OE-Core almost 7 years ago:
> https://git.openembedded.org/openembedded-core/commit/?id=2b15451e3f1b9fb9a7f44317f3f9cd22d8712ff5
>
> Moreover, gstreamer builds have migrated from autotools to meson around the
> same time and this "common" submodule/tree hasn't been used or updated for
> quite some time. Unfortunaly, gst-plugins-ti haven't been touched for 5 years
> and still use the old (ancient) "common" submodule for autotools stuff...
>
> So, proper, but most involved solution would be to migrate gst-plugins-ti to
> use meson.
>
> Otherwise, you can add the "common" tree to SRC_URI and set the corresponding
> SRCREV. That should satisfy git submodule update, but may need extra tweaking.
>
> SRC_URI += "git://anongit.freedesktop.org/gstreamer/common;destsuffix=git/common;name=common"
> SRCREV_common = "011bcc8a0fc7f798ee874a7ba899123fb2470e22"
This is exactly what I was hoping to hear. That it there was the
possibility of condensing the network stuff into the SRC_URI to be a
little more yocto compliant. I agree that long term all of the stuff
should be moved to meson like the main gstreamer.
> BTW, this commit ^^^ that is used for "common" submodule in gst-plugins-ti
> is 13 years old and dated 2010-10-27!!!
>
>
>>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>>> ---
>>> .../gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb | 2 ++
>>> .../gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb | 2 ++
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb
>>> index 1ff2dfb0..99a5615c 100644
>>> --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb
>>> +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-ducati_git.bb
>>> @@ -18,4 +18,6 @@ SRC_URI = " \
>>> file://0001-gstducati-configure.ac-stop-using-export-symbols-reg.patch \
>>> "
>>> +do_configure[network] = "1"
>>> +
>>> FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
>>> diff --git a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb
>>> index 237031b1..25d4d9c2 100644
>>> --- a/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb
>>> +++ b/meta-arago-extras/recipes-multimedia/gst-plugins-ti/gstreamer1.0-plugins-vpe_git.bb
>>> @@ -15,3 +15,5 @@ SRCREV = "b9dba5a8bc7d14d55125abdce04672e3dc30bbdf"
>>> SRC_URI = "git://git.ti.com/git/glsdk/gst-plugin-vpe.git;protocol=https \
>>> file://0001-gstvpe-configure.ac-stop-using-export-symbols-regex.patch \
>>> "
>>> +
>>> +do_configure[network] = "1"
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
next prev parent reply other threads:[~2023-12-07 0:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 14:36 [meta-arago][krikstone][PATCH RFC 0/4] Add gstreamer 1.20 Sinthu Raja
2023-12-06 14:36 ` [meta-arago][krikstone][PATCH RFC 1/4] gstreamer1.0-plugins-bad: Add patches to support DRM allocator Sinthu Raja
2023-12-06 14:36 ` [meta-arago][krikstone][PATCH RFC 2/4] gst-plugins-ti: Enable network task flag for do_configure Sinthu Raja
2023-12-06 15:33 ` Ryan Eatmon
2023-12-06 22:38 ` Denys Dmytriyenko
2023-12-07 0:57 ` Ryan Eatmon [this message]
2023-12-06 14:36 ` [meta-arago][krikstone][PATCH RFC 3/4] ti-test: Remove OAMP-DRM test Sinthu Raja
2023-12-06 17:05 ` Andrew Davis
2023-12-06 14:36 ` [meta-arago][krikstone][PATCH RFC 4/4] branding-core: enable mmip for AM57x platform Sinthu Raja
2023-12-06 15:35 ` Ryan Eatmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658f7403-cb11-4a9f-a85c-7c705295edd0@ti.com \
--to=reatmon@ti.com \
--cc=denis@denix.org \
--cc=denys@konsulko.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=praneeth@ti.com \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).