From: Rahul T R <r-ravikumar@ti.com>
To: <meta-arago@lists.yoctoproject.org>
Cc: <reatmon@ti.com>, <devarsht@ti.com>, <j-luthra@ti.com>,
<denys@ti.com>, <r-ravikumar@ti.com>, <b-brnich@ti.com>,
<p-mantena@ti.com>
Subject: [meta-arago][master/kirkstone][PATCH v3 2/2] gstreamer1.0-plugins-good: Add patch to increase min buffers for CSI capture
Date: Thu, 25 Jan 2024 13:27:10 +0530 [thread overview]
Message-ID: <20240125075710.843604-3-r-ravikumar@ti.com> (raw)
In-Reply-To: <20240125075710.843604-1-r-ravikumar@ti.com>
This is required to avoid the frame drops and increase the tolrence
for CSI capture using gsteamer
Signed-off-by: Rahul T R <r-ravikumar@ti.com>
---
...ct-Increase-min-buffers-for-CSI-capt.patch | 34 +++++++++++++++++++
.../gstreamer1.0-plugins-good_1.20.%.bbappend | 3 +-
2 files changed, 36 insertions(+), 1 deletion(-)
create mode 100644 meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
new file mode 100644
index 00000000..a981b037
--- /dev/null
+++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch
@@ -0,0 +1,34 @@
+From 48c3063b6704921fc46b718ea06281c79ec892ef Mon Sep 17 00:00:00 2001
+From: Rahul T R <r-ravikumar@ti.com>
+Date: Tue, 10 Oct 2023 14:42:13 +0530
+Subject: [PATCH] HACK: gstv4l2object: Increase min buffers for CSI capture
+
+With default min buffers, frame drops are observed with CSI capture
+pipeline with VISS, LDC and DSS with DMABuf Import mode
+
+Increasing min buffers queued in v4l2src seems to fix this issue.
+Need more amalysis on the exact root cause
+
+Upstream-Status: Pending
+
+Signed-off-by: Rahul T R <r-ravikumar@ti.com>
+---
+ sys/v4l2/gstv4l2object.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c
+index 4ce9fac..9f5a85b 100644
+--- a/sys/v4l2/gstv4l2object.c
++++ b/sys/v4l2/gstv4l2object.c
+@@ -5172,6 +5172,8 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * obj, GstQuery * query)
+ * pool, we'll need what the driver one, and one more, so we can dequeu */
+ if (0 == strcmp(obj->vcap.driver, "wave5-dec")) {
+ own_min = obj->min_buffers + 3;
++ } else if (0 == strcmp(obj->vcap.driver, "j721e-csi2rx")) {
++ own_min = obj->min_buffers + 4;
+ } else {
+ own_min = obj->min_buffers + 1;
+ }
+--
+2.34.1
+
diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
index 2a1a6e68..782b54a4 100644
--- a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
+++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.20.%.bbappend
@@ -5,6 +5,7 @@ SRC_URI:append = " \
file://0002-Adding-support-for-bayer-formats-with-IR-component.patch \
file://0003-v4l2-Changes-for-DMA-Buf-import-j721s2.patch \
file://0004-v4l2-Give-preference-to-contiguous-format-if-support.patch \
+ file://0005-HACK-gstv4l2object-Increase-min-buffers-for-CSI-capt.patch \
"
-PR:append = ".arago1"
+PR:append = ".arago2"
--
2.34.1
prev parent reply other threads:[~2024-01-25 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 7:57 [meta-arago][master/kirkstone][PATCH v3 0/2] Increase min buffers or CSI capture Rahul T R
2024-01-25 7:57 ` [meta-arago][master/kirkstone][PATCH v3 1/2] gstreamer1.0-plugins-good: Maintain same set of patches for all machines Rahul T R
2024-01-25 7:57 ` Rahul T R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125075710.843604-3-r-ravikumar@ti.com \
--to=r-ravikumar@ti.com \
--cc=b-brnich@ti.com \
--cc=denys@ti.com \
--cc=devarsht@ti.com \
--cc=j-luthra@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=p-mantena@ti.com \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).