From: Chirag Shilwant <c-shilwant@ti.com>
To: Denys Dmytriyenko <denis@denix.org>, Ryan Eatmon <reatmon@ti.com>
Cc: <meta-arago@lists.yoctoproject.org>, Gyan Gupta <g-gupta@ti.com>,
<dannenberg@ti.com>
Subject: Re: [meta-arago][master/scarthgap][PATCH] meta-arago-distro: recipes-core: Add no-fstab-update option to WIC_CREATE_EXTRA_ARG
Date: Thu, 25 Apr 2024 10:32:46 +0530 [thread overview]
Message-ID: <1ad73612-871f-49bd-a9c6-0c06d51debcb@ti.com> (raw)
In-Reply-To: <20240424201023.GE28791@denix.org>
Hi Denys,
On 25/04/24 01:40, Denys Dmytriyenko wrote:
> On Wed, Apr 24, 2024 at 08:32:52AM -0500, Ryan Eatmon wrote:
>>
>> On 4/22/2024 5:32 PM, Denys Dmytriyenko wrote:
>>> On Sun, Apr 21, 2024 at 02:42:23PM +0530, Chirag Shilwant wrote:
>>>> + Andreas
>>>> On 21/04/24 08:37, Denys Dmytriyenko wrote:
>>>>> On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote:
>>>>>> - Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition
>>>>>> but currently it lists the contents of /boot partition of the WIC Image.
>>>>>>
>>>>>> Eg - Incase of AM64x,
>>>>>> ```
>>>>>> root@am64xx-evm:~# ls /boot/
>>>>>> EFI Image tiboot3-am64x-gp-evm.bin tiboot3-am64x_sr2-hs-evm.bin tiboot3-am64x_sr2-hs-fs-evm.bin tiboot3.bin tispl.bin u-boot.img uEnv.txt
>>>>> Will this change affect EFI? As there's EFI directory in that partition.
>>>> The EFI partition under /rootfs/boot will still be present.
>>>> Following is the output of `ls /boot` with this patch,
>>>>
>>>> ```
>>>> root@am64xx-evm:~# ls /boot
>>>> EFI Image Image-6.1.80-ti-g2e423244f8c0 dtb fitImage
>>>> fitImage-6.1.80-ti-g2e423244f8c0
>>>>
>>>> ```
>>> Thanks, I'll do some additional testing with EFI a bit later.
>>>
>>>
>>>>>> - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc
>>>>>> to prevent WIC image from adding an additional entry in /etc/fstab.
>>>>> This flag is global and will prevent all other partitions from populating
>>>>> /etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other
>>>>> layers could have own wic files with e.g. /home or /data partitions. Mounting
>>>>> those will require a custom /etc/fstab instead of wic creating corresponding
>>>>> entries automatically.
>>>>>
>>>>
>>>> Apparently, this change was being carried in processor sdk layer from
>>>> quite a long time (from dunfell) to resolve a customer issue
>>>> reported by Andreas.
>>>> Diving into our internal JIRA system showed that this fix was
>>>> suggested by Andreas
>>>> & was resolved by the SDK team back then by keeping this change in
>>>> processor sdk layer [1].
>>>> Not sure why this was in processor sdk layer though. Maybe Andreas
>>>> can provide additional details.
>>> I tested and submitted a different fix last night to adjust WIC templates to
>>> not mount boot partition under /boot directory[1]. I still believe doing it
>>> just for that one partition is better than disabling fstab updates globally.
>>>
>>> [1] https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/
>> So with the above referenced patch in meta-ti, I'm assuming we do
>> not need this patch in meta-arago?
> That's my pitch here.
>
> Chirag,
>
> Will that work for you and others?
Let me kickoff a build with your meta-ti patch [1] & see if that works
for us as well.
Will get back in a day or two.
[1]:
https://patchwork.yoctoproject.org/project/ti/patch/20240421191458.2221303-1-denis@denix.org/
>
>
>>> Can you please take a look and maybe test this option for your use case?
>>> Thanks.
next prev parent reply other threads:[~2024-04-25 5:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 12:53 [meta-arago][master/scarthgap][PATCH] meta-arago-distro: recipes-core: Add no-fstab-update option to WIC_CREATE_EXTRA_ARG Chirag Shilwant
2024-04-21 3:07 ` Denys Dmytriyenko
2024-04-21 9:12 ` Chirag Shilwant
2024-04-21 18:19 ` Jon Cormier
2024-04-22 22:32 ` Denys Dmytriyenko
2024-04-23 0:05 ` Jon Cormier
2024-04-24 20:08 ` Denys Dmytriyenko
2024-04-24 13:32 ` Ryan Eatmon
2024-04-24 20:10 ` Denys Dmytriyenko
2024-04-25 5:02 ` Chirag Shilwant [this message]
[not found] ` <17C96D5BC5250FE5.19690@lists.yoctoproject.org>
2024-04-25 9:13 ` [EXTERNAL] " Chirag Shilwant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ad73612-871f-49bd-a9c6-0c06d51debcb@ti.com \
--to=c-shilwant@ti.com \
--cc=dannenberg@ti.com \
--cc=denis@denix.org \
--cc=g-gupta@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).