From: Joshua Watt <jpewhacker@gmail.com>
To: tim.orling@konsulko.com
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] contributor-guide: recommend format.forceInBodyFrom
Date: Thu, 2 May 2024 09:37:47 -0600 [thread overview]
Message-ID: <CAJdd5GYyNK5qq-CKH=WHQRAZLxhJN45Nz8xYtKkO3MpYDXiBhQ@mail.gmail.com> (raw)
In-Reply-To: <20240502152701.1798568-2-tim.orling@konsulko.com>
On Thu, May 2, 2024 at 9:27 AM Tim Orling via lists.yoctoproject.org
<tim.orling=konsulko.com@lists.yoctoproject.org> wrote:
>
> We are seeing a lot of patches failing when the From:
> line is not contained in the message body. It is probably
> better to just recommend to force the in-body From: to be
> present globally.
>
> Signed-off-by: Tim Orling <tim.orling@konsulko.com>
> ---
> documentation/contributor-guide/submit-changes.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst
> index 47a416b24..c292a143a 100644
> --- a/documentation/contributor-guide/submit-changes.rst
> +++ b/documentation/contributor-guide/submit-changes.rst
> @@ -65,6 +65,11 @@ use to identify your commits::
> git config --global user.name "Ada Lovelace"
> git config --global user.email "ada.lovelace@gmail.com"
>
> +To ensure that your patches are formatted properly, it is also
> +recommended to set::
> +
> + git config --global format.forceInBodyFrom true
> +
This is good, but we will probably need to clarify that there is a git
version dependency here. Git 2.34.1 (at least) doesn't have this
option. I'm not sure when it was added. It appears that 2.34 is the
version that ships with Ubuntu 22.04
> Clone the Git repository for the component to modify
> ----------------------------------------------------
>
> --
> 2.43.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#5199): https://lists.yoctoproject.org/g/docs/message/5199
> Mute This Topic: https://lists.yoctoproject.org/mt/105864996/3616693
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [JPEWhacker@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2024-05-02 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 15:27 [PATCH] contributor-guide: recommend format.forceInBodyFrom Tim Orling
2024-05-02 15:37 ` Joshua Watt [this message]
2024-05-02 16:12 ` [docs] " Tim Orling
[not found] ` <17CBB7F2FCD711F1.29540@lists.yoctoproject.org>
2024-05-02 16:23 ` Tim Orling
2024-05-02 19:18 ` Alexandre Belloni
2024-05-02 19:25 ` [docs] " Joshua Watt
2024-05-02 19:45 ` Alexandre Belloni
2024-05-02 20:15 ` Alexander Kanavin
2024-05-02 20:22 ` Tim Orling
2024-05-02 20:53 ` Alexander Kanavin
[not found] ` <17CBC7546C174761.19168@lists.yoctoproject.org>
2024-05-03 9:23 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJdd5GYyNK5qq-CKH=WHQRAZLxhJN45Nz8xYtKkO3MpYDXiBhQ@mail.gmail.com' \
--to=jpewhacker@gmail.com \
--cc=docs@lists.yoctoproject.org \
--cc=tim.orling@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).