From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: "Simone Weiß" <simone.p.weiss@posteo.com>
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] dev-manual: gen-tapdevs need iptables installed
Date: Mon, 5 Feb 2024 12:12:18 +0100 [thread overview]
Message-ID: <9c1772fe-0423-4128-8563-5fdc7dc1c647@bootlin.com> (raw)
In-Reply-To: <17B012973AA0B915.1968@lists.yoctoproject.org>
Hi Simone
On 2/2/24 at 15:38, Michael Opdenacker via lists.yoctoproject.org wrote:
> Hi Simone
>
> On 2/1/24 at 17:50, Simone Weiß wrote:
>> From: Simone Weiß <simone.p.weiss@posteo.com>
>>
>> Add the hint to the test setup that runqemu-gen-tapdevs will need the
>> iptables package installed.
>>
>> Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com>
>> ---
>> documentation/dev-manual/runtime-testing.rst | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/documentation/dev-manual/runtime-testing.rst
>> b/documentation/dev-manual/runtime-testing.rst
>> index be1e8c02e..1a2e9ec4f 100644
>> --- a/documentation/dev-manual/runtime-testing.rst
>> +++ b/documentation/dev-manual/runtime-testing.rst
>> @@ -52,6 +52,8 @@ In order to run tests, you need to do the following:
>> - Be sure to use an absolute path when calling this script
>> with sudo.
>> + - Ensure that your host has the package ``iptables``
>> installed.
>> +
>> - The package recipe ``qemu-helper-native`` is required
>> to run
>> this script. Build the package using the following
>> command::
>
>
> Thanks for the patch, but it doesn't apply with "git am" on
> "master-next". Did you send it with "git send-email", or was the patch
> messed-up by your mail server?
>
> Applying: dev-manual: gen-tapdevs need iptables installed
>
> error: patch failed: documentation/dev-manual/runtime-testing.rst:52
>
> error: documentation/dev-manual/runtime-testing.rst: patch does not apply
>
> Patch failed at 0001 dev-manual: gen-tapdevs need iptables installed
>
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
>
> When you have resolved this problem, run "git am --continue".
>
> If you prefer to skip this patch, run "git am --skip" instead.
>
> To restore the original branch and stop patching, run "git am --abort".
>
> Of course, I could re-create the patch, but that's interesting to
> solve this issue for next time.
Never mind, the problem is probably on my side. It seems I tried to
apply it twice, so everything's OK now and the patch is in "master-next".
Thanks again
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-02-05 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 16:50 [PATCH] dev-manual: gen-tapdevs need iptables installed simone.p.weiss
2024-02-02 14:38 ` [docs] " Michael Opdenacker
[not found] ` <17B012973AA0B915.1968@lists.yoctoproject.org>
2024-02-05 11:12 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1772fe-0423-4128-8563-5fdc7dc1c647@bootlin.com \
--to=michael.opdenacker@bootlin.com \
--cc=docs@lists.yoctoproject.org \
--cc=simone.p.weiss@posteo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).