From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: BELHADJ SALEM Talel <bhstalel@gmail.com>
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH v2] overview-manual: concepts: Add Bitbake Tasks Map
Date: Thu, 2 Nov 2023 16:08:10 +0100 [thread overview]
Message-ID: <660b0615-73ba-4eb0-b69d-d15a884bf1a0@bootlin.com> (raw)
In-Reply-To: <20231101084020.92934-1-bhstalel@gmail.com>
Hi Talel,
Many thanks for this update and taking all my comments into account.
On 01.11.23 at 09:40, BELHADJ SALEM Talel wrote:
> Create a Map to detail how BitBake handles a recipe's tasks
> and its compile/runtime dependencies along with detailed comments.
>
> Signed-off-by: Talel BELHAJSALEM <bhstalel@gmail.com>
> ---
> documentation/overview-manual/concepts.rst | 166 ++++++++++++++++++
> .../overview-manual/svg/bitbake_tasks_map.svg | 4 +
> 2 files changed, 170 insertions(+)
> create mode 100644 documentation/overview-manual/svg/bitbake_tasks_map.svg
I'm going to accept your patch, with these minor changes already
applied, for your information:
--- a/documentation/overview-manual/concepts.rst
+++ b/documentation/overview-manual/concepts.rst
@@ -2227,12 +2227,16 @@ Before presenting the contents of each file, here are the steps
that we need to follow to accomplish what we want in the first place,
which is integrating ``sayhello`` in our root file system:
-#. Create a Git repository for each project with the corresponding files
-#. Create a recipe for each project
-#. Make sure that ``sayhello`` recipe :term:`DEPENDS` on ``libhello``
-#. Make sure that ``sayhello`` recipe :term:`RDEPENDS` on ``libhello``
-#. Add ``sayhello`` to :term:`IMAGE_INSTALL` to integrate it into
- the root file system
+#. Create a Git repository for each project with the corresponding files
+
+#. Create a recipe for each project
+
+#. Make sure that ``sayhello`` recipe :term:`DEPENDS` on ``libhello``
+
+#. Make sure that ``sayhello`` recipe :term:`RDEPENDS` on ``libhello``
+
+#. Add ``sayhello`` to :term:`IMAGE_INSTALL` to integrate it into
+ the root file system
The following are the contents of ``libhello/Makefile``::
@@ -2252,7 +2256,7 @@ The following are the contents of ``libhello/Makefile``::
.. note::
When creating shared libraries, it is strongly recommended to follow the Linux
- conventions and guidelines. (see `this article
+ conventions and guidelines (see `this article
<https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html>`__
for some background).
@@ -2353,5 +2357,5 @@ to build the recipe.
The following diagram shows the sequences of tasks that BitBake
executes to accomplish that.
-.. image:: svg/bitbake_tasks_map.svg
+.. image:: svg/bitbake_tasks_map.*
:width: 100%
This being said, I am facing a last issue with Inkscape. The numbered
disks are rendered in black (you don't see the numbers), while this
doesn't happen with the black boxes with "D", "S"....
You can check this by opening the SVG file with Inkscape or running
"make latexpdf" and opening the resulting PDF in
_build/latex/theyoctoproject.pdf
Would you mind having a look so that we can fix it in an upcoming
commit? We need to make sure people can edit the diagram using Inkscape.
Merged in master-next anyway.
Thanks again
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2023-11-02 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 8:40 [PATCH v2] overview-manual: concepts: Add Bitbake Tasks Map Talel BELHAJSALEM
2023-11-02 15:08 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=660b0615-73ba-4eb0-b69d-d15a884bf1a0@bootlin.com \
--to=michael.opdenacker@bootlin.com \
--cc=bhstalel@gmail.com \
--cc=docs@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).