($INBOX_DIR/description missing)
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	luca.ceresoli@bootlin.com
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] ref-manual: tasks: do_cleanall: mention it is not allowed with a shared DL_DIR
Date: Tue, 20 Feb 2024 11:20:52 +0100	[thread overview]
Message-ID: <619be673-eb4e-46e5-83d0-478e17ac2e9c@theobroma-systems.com> (raw)
In-Reply-To: <9b8bddd6a7eb48e2aadfdbc4ae5b2b8a5be7f280.camel@linuxfoundation.org>

Hi all,

On 2/20/24 10:01, Richard Purdie wrote:
> On Tue, 2024-02-20 at 08:58 +0100, Luca Ceresoli via
> lists.yoctoproject.org wrote:
>> Hi Quentin,
>>
>> On Mon, 19 Feb 2024 17:12:46 +0100
>> Quentin Schulz <quentin.schulz@theobroma-systems.com> wrote:
>>
>>> Hi Luca,
>>>
>>> On 2/19/24 16:55, Luca Ceresoli via lists.yoctoproject.org wrote:
>>>> [You don't often get email from
>>>> luca.ceresoli=bootlin.com@lists.yoctoproject.org. Learn why this
>>>> is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>>
>>>> do_cleanall can produce failures if using a shared download
>>>> directory. This
>>>> is why it is forbidden when writing tests that will run on the
>>>> autobuilders
>>>> (
>>>> https://docs.yoctoproject.org/test-manual/intro.html?highlight=cle
>>>> anall#considerations-when-writing-tests).
>>>>
>>>> Reported-by: Sam Liddicott
>>>> Link:
>>>> https://bootlin.com/blog/yocto-sharing-the-sstate-cache-and-download-directories/#comment-2650335
>>>> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>>>> ---
>>>>    documentation/ref-manual/tasks.rst | 13 +++++++++++++
>>>>    1 file changed, 13 insertions(+)
>>>>
>>>> diff --git a/documentation/ref-manual/tasks.rst
>>>> b/documentation/ref-manual/tasks.rst
>>>> index 0db960b22f80..c754eb15514b 100644
>>>> --- a/documentation/ref-manual/tasks.rst
>>>> +++ b/documentation/ref-manual/tasks.rst
>>>> @@ -474,6 +474,19 @@ Typically, you would not normally use the
>>>> :ref:`ref-tasks-cleanall` task. Do so
>>>>    if you want to start fresh with the :ref:`ref-tasks-fetch`
>>>>    task.
>>>>
>>>> +.. note::
>>>> +
>>>> +   Never run the :ref:`ref-tasks-cleanall` task if your
>>>> :term:`DL_DIR` is
>>>
>>> This also applies if SSTATE_DIR is shared I believe?
>>
>> I don't think so. As far as I understand the sstate cache, a cache
>> entry is either found or not found, while for the downloads there is
>> the strange state of having a do_fetch stamp but no downloaded
>> archive.
>>
>> However I may be wrong. Do you have an example command sequence where
>> do_cleansstate can create a build failure?
> 
> The builds check sstate "up front" then download later so it if is
> deleted in the meantime, it will cause an error but not a total failure
> as it will rebuild it.
> 
> We therefore don't recommend cleansstate on a shared sstate directory.
> Instead you can use -f to invalidate a task.
> 

And considering that cleanall also calls cleansstate (or at least does 
the same), it applies and we should document it :)

Cheers,
Quentin


      reply	other threads:[~2024-02-20 10:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 15:55 [PATCH] ref-manual: tasks: do_cleanall: mention it is not allowed with a shared DL_DIR Luca Ceresoli
2024-02-19 16:12 ` [docs] " Quentin Schulz
2024-02-20  7:58   ` Luca Ceresoli
2024-02-20  9:01     ` Richard Purdie
2024-02-20 10:20       ` Quentin Schulz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=619be673-eb4e-46e5-83d0-478e17ac2e9c@theobroma-systems.com \
    --to=quentin.schulz@theobroma-systems.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).