($INBOX_DIR/description missing)
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: quentin.schulz@theobroma-systems.com,
	Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH v3 2/2] ref-manual: tasks: do_cleansstate: recommend using '-f' instead for a shared sstate
Date: Thu, 29 Feb 2024 12:07:11 +0100	[thread overview]
Message-ID: <24ed4572-8008-48c8-8884-af215d313742@bootlin.com> (raw)
In-Reply-To: <f21a5175-3c01-4bf4-9285-3a1ecda302ad@theobroma-systems.com>

Luca, Quentin,

Many thanks for the patches and reviews!

On 2/28/24 at 12:46, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Luca,
>
> On 2/28/24 12:25, Luca Ceresoli wrote:
>> do_cleansstat can produce build errors when using a shared sstate cache.
>>
>> Add a note to clearly discourage, provide a safe alternative (bitbake 
>> -f),
>> and the rationale.
>>
>> Proposed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> In poky:
> $ git log --oneline --grep "Proposed-by" | wc -l
> 2
> $ git log --oneline --grep "Suggested-by" | wc -l
> 46
>
> https://git-scm.com/docs/SubmittingPatches#sign-off also only mentions 
> Suggested-by as a trailer.
>
> Not really important, it just surprised me to see this trailer for the 
> first time :)

I fixed this in the commit.

>
> For the whole series,
>
> Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>


Merged into "master-next"
Thanks again.
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



      reply	other threads:[~2024-02-29 11:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 11:25 [PATCH v3 0/2] Discourage using do_cleansstate and do_cleanall Luca Ceresoli
2024-02-28 11:25 ` [PATCH v3 1/2] ref-manual: tasks: do_cleanall: recommend using '-f' instead Luca Ceresoli
2024-02-28 11:25 ` [PATCH v3 2/2] ref-manual: tasks: do_cleansstate: recommend using '-f' instead for a shared sstate Luca Ceresoli
2024-02-28 11:46   ` Quentin Schulz
2024-02-29 11:07     ` Michael Opdenacker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24ed4572-8008-48c8-8884-af215d313742@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).