From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: YP docs mailing list <docs@lists.yoctoproject.org>
Subject: Re: [docs] strange wording to explain BB_ENV_PASSTHROUGH?
Date: Mon, 4 Mar 2024 11:50:08 +0100 [thread overview]
Message-ID: <16fc31e1-ec00-4400-a458-215509c1f778@bootlin.com> (raw)
In-Reply-To: <b74ee0e8-5f40-293f-7da2-b66a8c167317@crashcourse.ca>
Hi Robert
On 3/3/24 at 13:19, Robert P. J. Day wrote:
> reading this:
>
> https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html#term-BB_ENV_PASSTHROUGH
>
> it seems visually odd that that variable, if not "specified", is
> defined in terms of a list of variables that includes itself.
>
> but the text before that also reads weirdly:
>
> "If the value of this variable is not specified (which is the
> default)..."
>
> Does this mean, if the variable does not have a value? Or that you
> haven't specified it? Or what? The wording seems confusing.
Thanks for reporting this issue. Good catch!
Actually, there could be an issue in the code.
Looking at
https://git.openembedded.org/bitbake/tree/lib/bb/utils.py#n664, it seems
that when the variable is not set in the environment,
approved_variables() takes a value that contains BB_ENV_PASSTHROUGH
(https://git.openembedded.org/bitbake/tree/lib/bb/utils.py#n607)!
I also checked on a possible default value for BB_ENV_PASSTHROUGH when
it is not set in the environment, and got nothing:
$ bitbake-getvar -r core-image-full-cmdline BB_ENV_PASSTHROUGH
The variable 'BB_ENV_PASSTHROUGH' is not defined
I feel like submitting a patch as a way to confirm that
BB_ENV_PASSTHROUGH can be removed from the code mentioned above.
This will help to fix this part of the docs.
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-03-04 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 12:19 strange wording to explain BB_ENV_PASSTHROUGH? Robert P. J. Day
2024-03-04 10:50 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16fc31e1-ec00-4400-a458-215509c1f778@bootlin.com \
--to=michael.opdenacker@bootlin.com \
--cc=docs@lists.yoctoproject.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).