From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: joerg.sommer@navimatix.de
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] kernel-dev: join mkdir commands with -p
Date: Mon, 8 Apr 2024 09:07:35 +0200 [thread overview]
Message-ID: <0d11df44-5226-4daa-a0ab-9dc32a15eafc@bootlin.com> (raw)
In-Reply-To: <31036f61cb79b07a4e774d799ec7bb8cf0bdbf07.1712312060.git.joerg.sommer@navimatix.de>
Hi Jörg
Thanks for the patch!
On 4/5/24 at 12:14, Jörg Sommer via lists.yoctoproject.org wrote:
> From: Jörg Sommer <joerg.sommer@navimatix.de>
>
> To make it more obvious which directories are needed, pass only these to
> *mkdir* and use the option `-p` to create the missing parents.
>
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> ---
> documentation/kernel-dev/common.rst | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/documentation/kernel-dev/common.rst b/documentation/kernel-dev/common.rst
> index 0cee503346..9a7a1907f6 100644
> --- a/documentation/kernel-dev/common.rst
> +++ b/documentation/kernel-dev/common.rst
> @@ -315,11 +315,7 @@ home directory:
>
> #. *Create Structure*: Create the layer's structure::
>
> - $ mkdir meta-mylayer
> - $ mkdir meta-mylayer/conf
> - $ mkdir meta-mylayer/recipes-kernel
> - $ mkdir meta-mylayer/recipes-kernel/linux
> - $ mkdir meta-mylayer/recipes-kernel/linux/linux-yocto
> + $ mkdir -p meta-mylayer/conf meta-mylayer/recipes-kernel/linux/linux-yocto
>
> The ``conf`` directory holds your configuration files, while the
> ``recipes-kernel`` directory holds your append file and eventual
> @@ -964,9 +960,7 @@ Section.
> additional structure to your layer using the following commands::
>
> $ cd ~/meta-mylayer
> - $ mkdir recipes-kernel
> - $ mkdir recipes-kernel/linux
> - $ mkdir recipes-kernel/linux/linux-yocto
> + $ mkdir -p recipes-kernel recipes-kernel/linux/linux-yocto
I definitely agree with your change! That's giving bad advice otherwise.
Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Merged into master-next.
Thanks again
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-04-08 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 10:14 [PATCH] kernel-dev: join mkdir commands with -p joerg.sommer
2024-04-08 7:07 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d11df44-5226-4daa-a0ab-9dc32a15eafc@bootlin.com \
--to=michael.opdenacker@bootlin.com \
--cc=docs@lists.yoctoproject.org \
--cc=joerg.sommer@navimatix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).