From: Philippe Gerum <rpm@xenomai.org>
To: Florian Bezdeka <florian.bezdeka@siemens.com>
Cc: xenomai@lists.linux.dev
Subject: Re: dovetail: Build warning about missing __noreturn annotation
Date: Tue, 12 Mar 2024 18:15:56 +0100 [thread overview]
Message-ID: <87y1an5q11.fsf@xenomai.org> (raw)
In-Reply-To: <92265dca7efe0970f7dc37d8e9fd3d15a3367c34.camel@siemens.com>
Florian Bezdeka <florian.bezdeka@siemens.com> writes:
> On Tue, 2024-03-05 at 17:54 +0100, Philippe Gerum wrote:
>> Florian Bezdeka <florian.bezdeka@siemens.com> writes:
>>
>> > Hi Philippe,
>> >
>> > any idea why I get the following build warning on recent dovetail
>> > branches? I haven't checked that yet, but I think all branches >= 6.0
>> > might be "affected".
>> >
>> > The warning:
>> >
>> > vmlinux.o: warning: objtool: arch_do_IRQ_pipelined+0x53f: __sysvec_reboot() is missing a __noreturn annotation
>> >
>> > __sysvec_reboot calls stop_this_cpu() which is annotated with
>> > __noreturn. It's unclear to me why arch_do_IRQ_pipelined() is in the
>> > game here.
>> >
>>
>> Because the call to __sysvec_reboot() is expanded inline in
>> arch_do_IRQ_pipelined() via run_sysvec_on_irqstack_cond ->
>> call_on_irqstack_cond. This inner call is missing the annotation.
>>
>> The following patch would do the trick, although in a fairly ugly way:
>
> No better idea here... As it is already part of all relevant 6.x
> branches no follow up necessary.
>
> Thanks Philippe for taking care!
>
Np. I don't think there is any better way, so let's go with this.
--
Philippe.
prev parent reply other threads:[~2024-03-12 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 16:02 dovetail: Build warning about missing __noreturn annotation Florian Bezdeka
2024-03-05 16:54 ` Philippe Gerum
2024-03-12 16:01 ` Florian Bezdeka
2024-03-12 17:15 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1an5q11.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=florian.bezdeka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).