From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Xenomai <xenomai@lists.linux.dev>
Subject: Re: [ibevl][PATCH] Install tests under libexec/evl
Date: Mon, 22 Jan 2024 14:53:49 +0100 [thread overview]
Message-ID: <87h6j5fp8u.fsf@xenomai.org> (raw)
In-Reply-To: <55f09668-f73b-448e-8c4a-0d43c67af092@siemens.com>
Jan Kiszka <jan.kiszka@siemens.com> writes:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> /usr/[local/]tests is unconventional. Better move the test executables
> under the evl directory.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> tests/meson.build | 6 +++---
> utils/evl.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/meson.build b/tests/meson.build
> index b831725..140b862 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -79,7 +79,7 @@ test_programs = [
> foreach t : test_programs
> x = executable(t, t + '.c',
> install : true,
> - install_dir : 'tests',
> + install_dir : libexec_evl + '/tests',
> dependencies : [ libtest_dep, libevl_dep ]
> )
> endforeach
> @@ -93,7 +93,7 @@ foreach t : test_programs_with_m
> x = executable(t, t + '.c',
> c_args : '-Wno-array-bounds',
> install : true,
> - install_dir : 'tests',
> + install_dir : libexec_evl + '/tests',
> dependencies : [ libtest_dep, libevl_dep, m_dep ]
> )
> endforeach
> @@ -106,7 +106,7 @@ atomic_dep = cc.find_library('atomic', required : true)
> foreach t : test_programs_with_atomic
> x = executable(t, t + '.c',
> install : true,
> - install_dir : 'tests',
> + install_dir : libexec_evl + '/tests',
> dependencies : [ libtest_dep, libevl_dep, atomic_dep ]
> )
> endforeach
> diff --git a/utils/evl.c b/utils/evl.c
> index d14fce4..eed0d96 100644
> --- a/utils/evl.c
> +++ b/utils/evl.c
> @@ -124,7 +124,7 @@ int main(int argc, char *const argv[])
> if (ret < 0)
> error(1, ENOMEM, "%s", arg0);
>
> - testdir = find_install_dir(arg0, "tests");
> + testdir = find_install_dir(arg0, LIBEXECDIR "/evl/tests");
>
> setenv("EVL_CMDDIR", cmddir, 1);
> setenv("EVL_TESTDIR", testdir, 1);
Merged, thanks.
--
Philippe.
prev parent reply other threads:[~2024-01-22 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 7:53 [ibevl][PATCH] Install tests under libexec/evl Jan Kiszka
2024-01-22 13:53 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6j5fp8u.fsf@xenomai.org \
--to=rpm@xenomai.org \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).