From: Florian Bezdeka <florian.bezdeka@siemens.com>
To: rpm@xenomai.org
Cc: roman.hodek@siemens.com,
Fabian Scheler <Fabian.Scheler@siemens.com>,
xenomai@lists.linux.dev
Subject: Re: [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE
Date: Tue, 23 Apr 2024 13:42:47 +0200 [thread overview]
Message-ID: <636c38d0658c7d1148e3b434351492a1375cfa6d.camel@siemens.com> (raw)
In-Reply-To: <20240423104111.32385-1-Fabian.Scheler@siemens.com>
[To: Adding Philippe, the dovetail maintainer]
To Fabian, Roman:
Is that a drive-by fix or do you really have the IRQ pipelining
disabled. If disabled: We should discuss this internally!
To Philippe: Hope you can fetch the patch from the Xenomai list.
Thanks!
Best regards,
Florian
On Tue, 2024-04-23 at 12:41 +0200, Fabian Scheler wrote:
> Fixup b917e98008314b3c7596099f48ea98f541451083 introducing
> DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN only if CONFIG_IRQ_PIPELINE is
> defined.
>
> Reported-by: Roman Hodek <roman.hodek@siemens.com>
> Signed-off-by: Roman Hodek <roman.hodek@siemens.com>
> ---
> arch/x86/include/asm/idtentry.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
> index 9b936d3e76a2..307623b4e10e 100644
> --- a/arch/x86/include/asm/idtentry.h
> +++ b/arch/x86/include/asm/idtentry.h
> @@ -230,6 +230,7 @@ __visible __noreturn void __##func(struct pt_regs *regs)
>
> #define DEFINE_IDTENTRY_IRQ_PIPELINED(func) DEFINE_IDTENTRY_IRQ(func)
> #define DEFINE_IDTENTRY_SYSVEC_PIPELINED(vector, func) DEFINE_IDTENTRY_SYSVEC(func)
> +#define DEFINE_IDTENTRY_SYSVEC_PIPELINED_NORETURN(vector, func) DEFINE_IDTENTRY_SYSVEC(func)
> #define DEFINE_IDTENTRY_SYSVEC_SIMPLE_PIPELINED(vector, func) DEFINE_IDTENTRY_SYSVEC_SIMPLE(func)
>
> /**
> --
> 2.44.0
next prev parent reply other threads:[~2024-04-23 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 10:41 [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE Fabian Scheler
2024-04-23 11:42 ` Florian Bezdeka [this message]
2024-04-23 12:59 ` Philippe Gerum
2024-04-23 14:18 ` Florian Bezdeka
2024-04-23 14:21 ` Philippe Gerum
2024-04-24 8:58 ` Fabian Scheler
2024-04-24 8:58 ` [PATCH v2 dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE Fabian Scheler
2024-04-24 9:02 ` Scheler, Fabian
2024-04-23 13:04 ` AW: [PATCH dovetail] x86: irq_pipeline: Add missing definition for !CONFIG_IRQ_PIPELINE Hodek, Roman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=636c38d0658c7d1148e3b434351492a1375cfa6d.camel@siemens.com \
--to=florian.bezdeka@siemens.com \
--cc=Fabian.Scheler@siemens.com \
--cc=roman.hodek@siemens.com \
--cc=rpm@xenomai.org \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).