From: Florian Bezdeka <florian.bezdeka@siemens.com>
To: xenomai@lists.linux.dev, jan.kiszka@siemens.com
Cc: Florian Bezdeka <florian.bezdeka@siemens.com>
Subject: [PATCH 3/6] testsuite: smokey/spitest: Fix --keep-going in combination with --verbose
Date: Thu, 02 Nov 2023 15:41:44 +0100 [thread overview]
Message-ID: <20231030-flo-cleanup-testsuite-v1-3-0fb7bbd2d45f@siemens.com> (raw)
In-Reply-To: <20231030-flo-cleanup-testsuite-v1-0-0fb7bbd2d45f@siemens.com>
Printing a note about a failing test was skipped if
--keep-going was given at the cmdline. --verbose had no effect.
Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
---
testsuite/smokey/main.c | 5 +++--
testsuite/spitest/spitest.c | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/testsuite/smokey/main.c b/testsuite/smokey/main.c
index f24c1e990..11a359ade 100644
--- a/testsuite/smokey/main.c
+++ b/testsuite/smokey/main.c
@@ -40,10 +40,11 @@ int main(int argc, char *const argv[])
continue;
}
fails++;
+ if (smokey_verbose_mode)
+ smokey_note("test %s failed: %d", t->name,
+ -ret);
if (smokey_keep_going)
continue;
- if (smokey_verbose_mode)
- error(1, -ret, "test %s failed", t->name);
return 1;
}
smokey_note("%s OK", t->name);
diff --git a/testsuite/spitest/spitest.c b/testsuite/spitest/spitest.c
index 99d609403..0b9aa62dc 100644
--- a/testsuite/spitest/spitest.c
+++ b/testsuite/spitest/spitest.c
@@ -455,10 +455,11 @@ int main(int argc, char *const argv[])
continue;
}
fails++;
+ if (smokey_verbose_mode)
+ smokey_note("test %s failed: %d", t->name,
+ -ret);
if (smokey_keep_going)
continue;
- if (smokey_verbose_mode)
- error(1, -ret, "test %s failed", t->name);
return 1;
}
smokey_note("%s OK", t->name);
--
2.39.2
next prev parent reply other threads:[~2023-11-02 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 14:41 [PATCH 0/6] Minor testsuite cleanups Florian Bezdeka
2023-11-02 14:41 ` [PATCH 1/6] testsuite: vxworkstests: Do not try to call nonexistent binary Florian Bezdeka
2023-11-02 14:41 ` [PATCH 2/6] testsuite: smokey: Refactor smokey_run_extprog() Florian Bezdeka
2023-11-02 14:54 ` Jan Kiszka
2023-11-02 14:41 ` Florian Bezdeka [this message]
2023-11-02 14:41 ` [PATCH 4/6] testsuite: alchemytests: Skip pipe test if kernel support is missing Florian Bezdeka
2023-11-02 14:56 ` Jan Kiszka
2023-11-03 10:45 ` Florian Bezdeka
2023-11-02 14:41 ` [PATCH 5/6] testsuite: vxworkstests: Skip tests if low resolution clock not enabled Florian Bezdeka
2023-11-02 14:41 ` [PATCH 6/6] testsuite: psostests: " Florian Bezdeka
2023-11-02 15:07 ` [PATCH 0/6] Minor testsuite cleanups Jan Kiszka
2023-11-03 14:36 ` Aaron Marcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030-flo-cleanup-testsuite-v1-3-0fb7bbd2d45f@siemens.com \
--to=florian.bezdeka@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).