From: Julien Grall <julien@xen.org>
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <Bertrand.Marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem
Date: Thu, 16 May 2024 22:23:15 +0100 [thread overview]
Message-ID: <fa9a1728-98a1-4b04-8965-8ec01d33b804@xen.org> (raw)
In-Reply-To: <F353B76B-D159-43A0-898F-EF8048342B07@arm.com>
Hi Luca,
On 15/05/2024 11:05, Luca Fancellu wrote:
>
>
>> On 14 May 2024, at 22:06, Julien Grall <julien@xen.org> wrote:
>>
>> Hi,
>>
>> On 14/05/2024 08:53, Luca Fancellu wrote:
>>> Hi Julien,
>>> Thanks for having a look on the patch,
>>>> On 13 May 2024, at 22:54, Julien Grall <julien@xen.org> wrote:
>>>>
>>>> Hi Luca,
>>>>
>>>> On 25/04/2024 14:11, Luca Fancellu wrote:
>>>>> Currently the code is listing device tree reserve map regions
>>>>> as reserved memory for Xen, but they are not added into
>>>>> bootinfo.reserved_mem and they are fetched in multiple places
>>>>> using the same code sequence, causing duplication. Fix this
>>>>> by adding them to the bootinfo.reserved_mem at early stage.
>>>>
>>>> Do we have enough space in bootinfo.reserved_mem for them?
>>> So we have 255 banks, in my experience I would say I’ve never saw too many reserved regions
>>> in the DT, maybe a couple, but I’ve always had to deal with embedded platforms.
>>> I’ve tested this one with ADLINK AVA board, n1sdp, Juno, raspberry pi, qemu, fvp.
>>> In your experience, have you seen any numbers that could be concerning?
>> I know in the past we had to bump the memory banks a few times. But as you tested on a few platforms, I think we should be ok.
>>
>> It would be best if this patch goes sooner than later to allow wider testing before we release 4.19.
>>
>> Acked-by: Julien Grall <jgrall@amazon.com>
>
> Yes it would make sense, this patch makes sense on its own, would you/anyone commit it separately while I work on the second
> patch?
Thank you for the confirmation. This is now committed.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2024-05-16 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 13:11 [RFC PATCH 0/2] xen/arm: Remove recursion from dt_unreserved_regions Luca Fancellu
2024-04-25 13:11 ` [RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem Luca Fancellu
2024-05-13 21:54 ` Julien Grall
2024-05-14 7:53 ` Luca Fancellu
2024-05-14 21:06 ` Julien Grall
2024-05-15 10:05 ` Luca Fancellu
2024-05-16 21:23 ` Julien Grall [this message]
2024-04-25 13:11 ` [RFC PATCH 2/2] xen/arm: Rework dt_unreserved_regions to avoid recursion Luca Fancellu
2024-05-13 22:16 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9a1728-98a1-4b04-8965-8ec01d33b804@xen.org \
--to=julien@xen.org \
--cc=Bertrand.Marquis@arm.com \
--cc=Luca.Fancellu@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).