From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Juergen Gross" <jgross@suse.com>,
"Christian Lindig" <christian.lindig@citrix.com>,
"Edwin Török" <edwin.torok@cloud.com>,
"Stefano Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd
Date: Wed, 1 May 2024 15:04:00 +0100 [thread overview]
Message-ID: <dcb9a57f-b002-46bd-a7dc-1cd580a9ab69@citrix.com> (raw)
In-Reply-To: <83160ad7-19b1-496f-a560-c11db67b1caf@perard>
On 01/05/2024 2:29 pm, Anthony PERARD wrote:
> On Fri, Apr 26, 2024 at 09:51:47AM +0100, Anthony PERARD wrote:
>> Run `systemd-notify --ready` instead. Hopefully, that will be enough.
>> ($NOTIFY_SOCKET is a socket, and a bit more complicated that I though,
>> it can start with "@" for example)
> FTR: If it turns out that calling systemd-notify binary isn't working
> well enough, we could have an implementation of sd_notify() in our tree,
> openssh are doing there own here:
> https://bugzilla.mindrot.org/show_bug.cgi?id=2641
> and there's an example implementation on systemd's documentation:
> https://www.freedesktop.org/software/systemd/man/devel/sd_notify.html#Notes
> (Nothing for ocaml)
>
> But let's go with `systemd-notify --ready` as it is just easier to
> write a bit of shell script.
I was already thinking of going down the small-library-function route.
Given that I miss-analysed the launch-xenstore, script, I'm not overly
enthused with just falling back to waiting on the pidfile, because
that's adding technical debt rather than removing it.
~Andrew
next prev parent reply other threads:[~2024-05-01 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 17:32 [PATCH 0/2] Drop libsystemd Andrew Cooper
2024-04-25 17:32 ` [PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd Andrew Cooper
2024-04-25 18:06 ` Anthony PERARD
2024-04-25 18:16 ` Andrew Cooper
2024-04-26 8:51 ` Anthony PERARD
2024-04-26 9:26 ` Andrew Cooper
2024-05-01 13:29 ` Anthony PERARD
2024-05-01 14:04 ` Andrew Cooper [this message]
2024-04-29 10:44 ` Jürgen Groß
2024-04-25 17:32 ` [PATCH 2/2] tools: Drop libsystemd as a dependency Andrew Cooper
2024-04-26 9:25 ` Anthony PERARD
2024-04-26 9:26 ` [PATCH 0/2] Drop libsystemd Christian Lindig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcb9a57f-b002-46bd-a7dc-1cd580a9ab69@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=edwin.torok@cloud.com \
--cc=jgross@suse.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).