From: "Oleksii K." <oleksii.kurochko@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony@xenproject.org>,
Juergen Gross <jgross@suse.com>,
Arthur Borsboom <arthurborsboom@gmail.com>,
Leigh Brown <leigh@solinno.co.uk>
Subject: Re: [PATCH for-4.19] libxl: fix population of the online vCPU bitmap for PVH
Date: Tue, 14 May 2024 11:08:48 +0200 [thread overview]
Message-ID: <c3cea2b9118392c7b4ddddd750dd97ac96e8ec7c.camel@gmail.com> (raw)
In-Reply-To: <df58677c-d9a3-43a7-b5b4-85565ad73b12@citrix.com>
On Fri, 2024-05-10 at 16:20 +0100, Andrew Cooper wrote:
> On 10/05/2024 1:49 pm, Roger Pau Monne wrote:
> > libxl passes some information to libacpi to create the ACPI table
> > for a PVH
> > guest, and among that information it's a bitmap of which vCPUs are
> > online
> > which can be less than the maximum number of vCPUs assigned to the
> > domain.
> >
> > While the population of the bitmap is done correctly for HVM based
> > on the
> > number of online vCPUs, for PVH the population of the bitmap is
> > done based on
> > the number of maximum vCPUs allowed. This leads to all local APIC
> > entries in
> > the MADT being set as enabled, which contradicts the data in
> > xenstore if vCPUs
> > is different than maximum vCPUs.
> >
> > Fix by copying the internal libxl bitmap that's populated based on
> > the vCPUs
> > parameter.
> >
> > Reported-by: Arthur Borsboom <arthurborsboom@gmail.com>
> > Link: https://gitlab.com/libvirt/libvirt/-/issues/399
> > Reported-by: Leigh Brown <leigh@solinno.co.uk>
> > Fixes: 14c0d328da2b ('libxl/acpi: Build ACPI tables for HVMlite
> > guests')
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > Note that the setup of hvm_info_table could be shared between PVH
> > and HVM, as
> > the fields are very limited, see hvm_build_set_params() for the HVM
> > side.
> > However this late in the release it's safer to just adjust the PVH
> > path.
> >
> > Also note the checksum is not provided when hvm_info_table is built
> > for PVH.
> > This is fine so far because such checksum is only consumed by
> > hvmloader and not
> > libacpi itself.
> >
> > It's a bugfix, so should be considered for 4.19.
>
> Bugfixes are still completely fair game at this point.
Considering that this is bugfixes I will be happy to have that in 4.19
release:
Release-acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
~ Oleksii
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
prev parent reply other threads:[~2024-05-14 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 12:49 [PATCH for-4.19] libxl: fix population of the online vCPU bitmap for PVH Roger Pau Monne
2024-05-10 13:15 ` Leigh Brown
2024-05-10 15:20 ` Andrew Cooper
2024-05-14 9:08 ` Oleksii K. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3cea2b9118392c7b4ddddd750dd97ac96e8ec7c.camel@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony@xenproject.org \
--cc=arthurborsboom@gmail.com \
--cc=jgross@suse.com \
--cc=leigh@solinno.co.uk \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).