* [PATCH] CI: Simplify RISCV smoke testing
@ 2023-02-24 15:37 Andrew Cooper
2023-02-24 16:47 ` Oleksii
2023-02-27 21:08 ` Stefano Stabellini
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2023-02-24 15:37 UTC (permalink / raw
To: Xen-devel
Cc: Andrew Cooper, Oleksii Kurochko, Bob Eshleman, Alistair Francis,
Connor Davis, Anthony PERARD, Stefano Stabellini, Michal Orzel,
Doug Goldstein
Use a single fairly generic string as the "all done" message to look for,
which avoids the need to patch qemu-smoke-riscv64.sh each time a new feature
is added.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
CC: Bob Eshleman <bobbyeshleman@gmail.com>
CC: Alistair Francis <alistair.francis@wdc.com>
CC: Connor Davis <connojdavis@gmail.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Michal Orzel <michal.orzel@amd.com>
CC: Doug Goldstein <cardoe@cardoe.com>
I considered "All set up and nowhere to go" but it's probably a little niche.
---
automation/scripts/qemu-smoke-riscv64.sh | 2 +-
xen/arch/riscv/setup.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh
index e0f06360bc43..4008191302f9 100755
--- a/automation/scripts/qemu-smoke-riscv64.sh
+++ b/automation/scripts/qemu-smoke-riscv64.sh
@@ -16,5 +16,5 @@ qemu-system-riscv64 \
|& tee smoke.serial
set -e
-(grep -q "Hello from C env" smoke.serial) || exit 1
+(grep -q "All set up" smoke.serial) || exit 1
exit 0
diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
index d09ffe1454a4..1c87899e8e90 100644
--- a/xen/arch/riscv/setup.c
+++ b/xen/arch/riscv/setup.c
@@ -11,6 +11,7 @@ void __init noreturn start_xen(void)
{
early_printk("Hello from C env\n");
+ early_printk("All set up\n");
for ( ;; )
asm volatile ("wfi");
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] CI: Simplify RISCV smoke testing
2023-02-24 15:37 [PATCH] CI: Simplify RISCV smoke testing Andrew Cooper
@ 2023-02-24 16:47 ` Oleksii
2023-02-27 21:08 ` Stefano Stabellini
1 sibling, 0 replies; 3+ messages in thread
From: Oleksii @ 2023-02-24 16:47 UTC (permalink / raw
To: Andrew Cooper, Xen-devel
Cc: Bob Eshleman, Alistair Francis, Connor Davis, Anthony PERARD,
Stefano Stabellini, Michal Orzel, Doug Goldstein
Looks good to me.
Thanks.
Reviewed-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
~ Oleksii
On Fri, 2023-02-24 at 15:37 +0000, Andrew Cooper wrote:
> Use a single fairly generic string as the "all done" message to look
> for,
> which avoids the need to patch qemu-smoke-riscv64.sh each time a new
> feature
> is added.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> CC: Bob Eshleman <bobbyeshleman@gmail.com>
> CC: Alistair Francis <alistair.francis@wdc.com>
> CC: Connor Davis <connojdavis@gmail.com>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Michal Orzel <michal.orzel@amd.com>
> CC: Doug Goldstein <cardoe@cardoe.com>
>
> I considered "All set up and nowhere to go" but it's probably a
> little niche.
> ---
> automation/scripts/qemu-smoke-riscv64.sh | 2 +-
> xen/arch/riscv/setup.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/automation/scripts/qemu-smoke-riscv64.sh
> b/automation/scripts/qemu-smoke-riscv64.sh
> index e0f06360bc43..4008191302f9 100755
> --- a/automation/scripts/qemu-smoke-riscv64.sh
> +++ b/automation/scripts/qemu-smoke-riscv64.sh
> @@ -16,5 +16,5 @@ qemu-system-riscv64 \
> |& tee smoke.serial
>
> set -e
> -(grep -q "Hello from C env" smoke.serial) || exit 1
> +(grep -q "All set up" smoke.serial) || exit 1
> exit 0
> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
> index d09ffe1454a4..1c87899e8e90 100644
> --- a/xen/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -11,6 +11,7 @@ void __init noreturn start_xen(void)
> {
> early_printk("Hello from C env\n");
>
> + early_printk("All set up\n");
> for ( ;; )
> asm volatile ("wfi");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] CI: Simplify RISCV smoke testing
2023-02-24 15:37 [PATCH] CI: Simplify RISCV smoke testing Andrew Cooper
2023-02-24 16:47 ` Oleksii
@ 2023-02-27 21:08 ` Stefano Stabellini
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2023-02-27 21:08 UTC (permalink / raw
To: Andrew Cooper
Cc: Xen-devel, Oleksii Kurochko, Bob Eshleman, Alistair Francis,
Connor Davis, Anthony PERARD, Stefano Stabellini, Michal Orzel,
Doug Goldstein
On Fri, 24 Feb 2023, Andrew Cooper wrote:
> Use a single fairly generic string as the "all done" message to look for,
> which avoids the need to patch qemu-smoke-riscv64.sh each time a new feature
> is added.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> CC: Bob Eshleman <bobbyeshleman@gmail.com>
> CC: Alistair Francis <alistair.francis@wdc.com>
> CC: Connor Davis <connojdavis@gmail.com>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Michal Orzel <michal.orzel@amd.com>
> CC: Doug Goldstein <cardoe@cardoe.com>
>
> I considered "All set up and nowhere to go" but it's probably a little niche.
> ---
> automation/scripts/qemu-smoke-riscv64.sh | 2 +-
> xen/arch/riscv/setup.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh
> index e0f06360bc43..4008191302f9 100755
> --- a/automation/scripts/qemu-smoke-riscv64.sh
> +++ b/automation/scripts/qemu-smoke-riscv64.sh
> @@ -16,5 +16,5 @@ qemu-system-riscv64 \
> |& tee smoke.serial
>
> set -e
> -(grep -q "Hello from C env" smoke.serial) || exit 1
> +(grep -q "All set up" smoke.serial) || exit 1
> exit 0
> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
> index d09ffe1454a4..1c87899e8e90 100644
> --- a/xen/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -11,6 +11,7 @@ void __init noreturn start_xen(void)
> {
> early_printk("Hello from C env\n");
>
> + early_printk("All set up\n");
> for ( ;; )
> asm volatile ("wfi");
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-27 21:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-24 15:37 [PATCH] CI: Simplify RISCV smoke testing Andrew Cooper
2023-02-24 16:47 ` Oleksii
2023-02-27 21:08 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).