From: Stefano Stabellini <sstabellini@kernel.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Sergiy Kibrik" <Sergiy_Kibrik@epam.com>,
xen-devel@lists.xenproject.org,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Xenia Ragiadakou" <xenia.ragiadakou@amd.com>
Subject: Re: [XEN PATCH v2 14/15] iommu/vt-d: guard vmx_pi_hooks_* calls with cpu_has_vmx
Date: Thu, 16 May 2024 16:41:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2405161640350.2544314@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <3104deae-0d27-438e-83ea-035a7786fd4a@suse.com>
On Thu, 16 May 2024, Jan Beulich wrote:
> On 16.05.2024 02:54, Stefano Stabellini wrote:
> > On Wed, 15 May 2024, Sergiy Kibrik wrote:
> >> VMX posted interrupts support can now be excluded from x86 build along with
> >> VMX code itself, but still we may want to keep the possibility to use
> >> VT-d IOMMU driver in non-HVM setups.
> >> So we guard vmx_pi_hooks_{assign/deassign} with some checks for such a case.
> >>
> >> No functional change intended here.
> >>
> >> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
> >
> > I know that Andrew was keep on having a separate Kconfig option for
> > VT-D, separate from VMX. But still, couldn't we make the VT-D Kconfig
> > option depending on CONFIG_VMX?
> >
> > To me, VT-D should require VMX, without VMX it should not be possible to
> > enable VT-D.
> >
> > This comment goes in the same direction of my previous comment regarding
> > the vpmu: we are trying to make things more configurable and flexible
> > and that's good, but we don't necessary need to make all possible
> > combination work. VT-D without VMX is another one of those combination
> > that I would only enable after a customer asks.
>
> Well. Imo again the configuration should be permitted.
FYI Andrew said the same thing as you on Matrix, so I withdraw my
suggestion.
next prev parent reply other threads:[~2024-05-16 23:42 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 8:57 [XEN PATCH v2 00/15] x86: make cpu virtualization support configurable Sergiy Kibrik
2024-05-15 8:59 ` [XEN PATCH v2 01/15] x86: introduce AMD-V and Intel VT-x Kconfig options Sergiy Kibrik
2024-05-16 10:09 ` Jan Beulich
2024-05-15 9:01 ` [XEN PATCH v2 02/15] x86/monitor: guard altp2m usage Sergiy Kibrik
2024-05-16 0:29 ` Stefano Stabellini
2024-05-16 10:20 ` Jan Beulich
2024-05-15 9:03 ` [XEN PATCH v2 03/15] x86/p2m: guard altp2m routines Sergiy Kibrik
2024-05-16 0:31 ` Stefano Stabellini
2024-05-16 10:26 ` Jan Beulich
2024-05-15 9:06 ` [XEN PATCH v2 04/15] x86/p2m: move altp2m-related code to separate file Sergiy Kibrik
2024-05-16 0:35 ` Stefano Stabellini
2024-05-16 11:46 ` Jan Beulich
2024-05-16 10:37 ` Jan Beulich
2024-05-15 9:08 ` [XEN PATCH v2 05/15] x86: introduce CONFIG_ALTP2M Kconfig option Sergiy Kibrik
2024-05-16 0:33 ` Stefano Stabellini
2024-05-16 10:41 ` Jan Beulich
2024-05-18 1:07 ` Tamas K Lengyel
2024-05-15 9:10 ` [XEN PATCH v2 06/15] x86/p2m: guard altp2m code with CONFIG_ALTP2M option Sergiy Kibrik
2024-05-16 0:38 ` Stefano Stabellini
2024-05-16 10:55 ` Jan Beulich
2024-05-16 11:01 ` Jan Beulich
2024-05-23 10:44 ` Sergiy Kibrik
2024-05-23 14:43 ` Jan Beulich
2024-05-15 9:12 ` [XEN PATCH v2 07/15] x86: guard cpu_has_{svm/vmx} macros with CONFIG_{SVM/VMX} Sergiy Kibrik
2024-05-16 0:38 ` Stefano Stabellini
2024-05-16 11:12 ` Jan Beulich
2024-05-23 13:07 ` Sergiy Kibrik
2024-05-23 14:50 ` Jan Beulich
2024-05-23 23:36 ` Stefano Stabellini
2024-05-24 6:49 ` Jan Beulich
2024-05-27 10:27 ` Sergiy Kibrik
2024-05-27 10:49 ` Jan Beulich
2024-05-15 9:14 ` [XEN PATCH v2 08/15] x86/vpmu: guard vmx/svm calls with cpu_has_{vmx,svm} Sergiy Kibrik
2024-05-16 0:44 ` Stefano Stabellini
2024-05-16 7:25 ` Jan Beulich
2024-05-16 11:23 ` Jan Beulich
2024-05-15 9:16 ` [XEN PATCH v2 09/15] x86/traps: clean up superfluous #idef-s Sergiy Kibrik
2024-05-16 0:45 ` Stefano Stabellini
2024-05-15 9:18 ` [XEN PATCH v2 10/15] x86/domain: " Sergiy Kibrik
2024-05-16 0:46 ` Stefano Stabellini
2024-05-15 9:20 ` [XEN PATCH v2 11/15] x86/oprofile: guard svm specific symbols with CONFIG_SVM Sergiy Kibrik
2024-05-15 9:22 ` [XEN PATCH v2 12/15] x86/vmx: guard access to cpu_has_vmx_* in common code Sergiy Kibrik
2024-05-16 0:50 ` Stefano Stabellini
2024-05-16 7:32 ` Jan Beulich
2024-05-29 10:58 ` Sergiy Kibrik
2024-05-29 12:16 ` Jan Beulich
2024-05-15 9:24 ` [XEN PATCH v2 13/15] x86/ioreq: guard VIO_realmode_completion with CONFIG_VMX Sergiy Kibrik
2024-05-16 0:51 ` Stefano Stabellini
2024-05-16 12:11 ` Jan Beulich
2024-05-31 8:05 ` Sergiy Kibrik
2024-05-31 8:31 ` Jan Beulich
2024-05-31 8:06 ` [XEN PATCH RFC] ioreq: make arch_vcpu_ioreq_completion() an optional callback Sergiy Kibrik
2024-05-15 9:26 ` [XEN PATCH v2 14/15] iommu/vt-d: guard vmx_pi_hooks_* calls with cpu_has_vmx Sergiy Kibrik
2024-05-16 0:54 ` Stefano Stabellini
2024-05-16 7:37 ` Jan Beulich
2024-05-16 23:41 ` Stefano Stabellini [this message]
2024-05-16 12:15 ` Jan Beulich
2024-05-15 9:28 ` [XEN PATCH v2 15/15] x86/hvm: make AMD-V and Intel VT-x support configurable Sergiy Kibrik
2024-05-16 0:54 ` Stefano Stabellini
2024-05-16 12:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2405161640350.2544314@ubuntu-linux-20-04-desktop \
--to=sstabellini@kernel.org \
--cc=Sergiy_Kibrik@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).