From: Christian Lindig <christian.lindig@cloud.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Anthony PERARD <anthony@xenproject.org>,
Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Christian Lindig <christian.lindig@citrix.com>,
David Scott <dave@recoil.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH for-4.19 v3 2/3] xen: enable altp2m at create domain domctl
Date: Fri, 17 May 2024 14:54:16 +0100 [thread overview]
Message-ID: <CB1A21D1-3557-4A9D-898C-FF8238ADCB11@cloud.com> (raw)
In-Reply-To: <20240517133352.94347-3-roger.pau@citrix.com>
> On 17 May 2024, at 14:33, Roger Pau Monne <roger.pau@citrix.com> wrote:
>
> Enabling it using an HVM param is fragile, and complicates the logic when
> deciding whether options that interact with altp2m can also be enabled.
>
> Leave the HVM param value for consumption by the guest, but prevent it from
> being set. Enabling is now done using and additional altp2m specific field in
> xen_domctl_createdomain.
>
> Note that albeit only currently implemented in x86, altp2m could be implemented
> in other architectures, hence why the field is added to xen_domctl_createdomain
> instead of xen_arch_domainconfig.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Changes since v2:
> - Introduce a new altp2m field in xen_domctl_createdomain.
>
> Changes since v1:
> - New in this version.
> ---
> tools/libs/light/libxl_create.c | 23 ++++++++++++++++++++++-
> tools/libs/light/libxl_x86.c | 26 ++++++++++++--------------
> tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +-
> xen/arch/arm/domain.c | 6 ++++++
> xen/arch/x86/domain.c | 22 ++++++++++++++++++++++
> xen/arch/x86/hvm/hvm.c | 23 ++++++++++++++++++++++-
> xen/include/public/domctl.h | 20 +++++++++++++++++++-
> xen/include/public/hvm/params.h | 9 ++-------
> 8 files changed, 106 insertions(+), 25 deletions(-)
>
> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
> index 2b6d3c09dfa0..c6da9bb09137 100644
> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
> @@ -257,7 +257,7 @@ CAMLprim value stub_xc_domain_create(value xch_val, value wanted_domid, value co
> #if defined(__i386__) || defined(__x86_64__)
>
> /* Quick & dirty check for ABI changes. */
> - BUILD_BUG_ON(sizeof(cfg) != 64);
> + BUILD_BUG_ON(sizeof(cfg) != 68);
>
Acked-by: Christian Lindig <christian.lindig@cloud.com>
next prev parent reply other threads:[~2024-05-17 13:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 13:33 [PATCH for-4.19 v3 0/3] xen/x86: support foreign mappings for HVM/PVH Roger Pau Monne
2024-05-17 13:33 ` [PATCH for-4.19 v3 1/3] xen/x86: account number of foreign mappings in the p2m Roger Pau Monne
2024-05-17 13:33 ` [PATCH for-4.19 v3 2/3] xen: enable altp2m at create domain domctl Roger Pau Monne
2024-05-17 13:54 ` Christian Lindig [this message]
2024-05-21 10:30 ` Jan Beulich
2024-05-22 13:16 ` Roger Pau Monné
2024-05-22 13:34 ` Jan Beulich
2024-05-22 16:21 ` Roger Pau Monné
2024-05-23 6:54 ` Jan Beulich
2024-05-23 11:36 ` Roger Pau Monné
2024-05-23 18:28 ` Stefano Stabellini
2024-05-24 13:28 ` Jürgen Groß
2024-05-17 13:33 ` [PATCH for-4.19 v3 3/3] xen/x86: remove foreign mappings from the p2m on teardown Roger Pau Monne
2024-05-29 7:24 ` [PATCH for-4.19 v3 0/3] xen/x86: support foreign mappings for HVM/PVH Jan Beulich
2024-05-29 7:41 ` Oleksii K.
2024-05-29 12:21 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB1A21D1-3557-4A9D-898C-FF8238ADCB11@cloud.com \
--to=christian.lindig@cloud.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony@xenproject.org \
--cc=bertrand.marquis@arm.com \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=dpsmith@apertussolutions.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).