From: Jason Andryuk <jason.andryuk@amd.com>
To: Jan Beulich <jbeulich@suse.com>, Jason Andryuk <jandryuk@gmail.com>
Cc: Anthony PERARD <anthony@xenproject.org>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] hotplug: Restore block-tap phy compatibility
Date: Thu, 16 May 2024 09:52:38 -0400 [thread overview]
Message-ID: <9678073f-82d5-4402-b5a0-e24985c1446b@amd.com> (raw)
In-Reply-To: <64083e01-edf1-4395-a9d7-82e82d220de7@suse.com>
On 2024-05-16 03:41, Jan Beulich wrote:
> On 16.05.2024 04:22, Jason Andryuk wrote:
>> From: Jason Andryuk <jason.andryuk@amd.com>
>>
>> From: Jason Andryuk <jason.andryuk@amd.com>
>
> Two identical From: (also in another patch of yours, while in yet another one
> you have two _different_ ones, when only one will survive into the eventual
> commit anyway)?
Sorry about that. Since I was sending from my gmail account, I thought
I needed explicit From: lines to ensure the authorship was listed w/
amd.com. I generated the patches with `git format-patch --from`, to get
the explicit From: lines, and then sent with `git send-email`. The
send-email step then inserted the additional lines. I guess it added
From amd.com since I had changed to that address in .gitconfig.
>> backendtype=phy using the blktap kernel module needs to use write_dev,
>> but tapback can't support that. tapback should perform better, but make
>> the script compatible with the old kernel module again.
>>
>> Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
>
> Should there be a Fixes: tag here?
That makes sense.
Fixes: 76a484193d ("hotplug: Update block-tap")
Thanks,
Jason
prev parent reply other threads:[~2024-05-16 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 2:22 [PATCH] hotplug: Restore block-tap phy compatibility Jason Andryuk
2024-05-16 7:41 ` Jan Beulich
2024-05-16 13:52 ` Jason Andryuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9678073f-82d5-4402-b5a0-e24985c1446b@amd.com \
--to=jason.andryuk@amd.com \
--cc=anthony@xenproject.org \
--cc=jandryuk@gmail.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).