From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Federico Serafini <federico.serafini@bugseng.com>,
xen-devel@lists.xenproject.org, consulting@bugseng.com,
Simone Ballarin <simone.ballarin@bugseng.com>,
Doug Goldstein <cardoe@cardoe.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [REGRESSION] Re: [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses
Date: Mon, 06 May 2024 08:45:45 +0200 [thread overview]
Message-ID: <8ddfbc0d6b20238cb902ccfccb2310fc@bugseng.com> (raw)
In-Reply-To: <b2857b11-9ae6-4768-bd0d-8c93b9a3d604@citrix.com>
On 2024-05-03 22:06, Andrew Cooper wrote:
> On 03/05/2024 9:01 pm, Federico Serafini wrote:
>> On 03/05/24 21:46, Andrew Cooper wrote:
>>> On 03/05/2024 8:44 pm, Federico Serafini wrote:
>>>> On 03/05/24 21:14, Andrew Cooper wrote:
>>>>> On 29/04/2024 4:21 pm, Federico Serafini wrote:
>>>>>> Patch 1/3 does some preparation work.
>>>>>>
Hi,
>>>>>> Patch 2/3, as the title says, removes allow_failure = true for
>>>>>> triggered
>>>>>> analyses.
>>>>>>
>>>>>> Patch 3/3 makes explicit that initally no files are tagged as
>>>>>> adopted, this
>>>>>> is needed by the scheduled analysis.
>>>>>
>>>>> I'm afraid that something in this series is broken.
>>>>>
>>>>> Since these patches went in, all pipelines are now getting a status
>>>>> of
>>>>> blocked rather than passed.
>>>>>
>>>>> If I manually start the Eclair jobs, then eventually the pipeline
>>>>> gets
>>>>> to Passed.
>>>>
>>>> Can you provide us a link to those failures?
>>>> I am looking at gitlab xen-project/xen and xen-project/patchew
>>>> and everything seems ok.
>>>>
>>>
>>> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1276081658
>>> is the first one I noticed as blocked, and I manually ran. That
>>> ended
>>> up working.
>>>
>>> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1277724847
>>> is still in the blocked state. The build-each-commit failure is
>>> unrelated.
>>
>> This is intentional and was introduced by
>> commit 7c1bf8661db5c00bd8c9a25015fe8678b2ff9ac6
>>
>> The ECLAIR analysis under people/* need to be activated
>> manually.
>
> Yes. I know, and that matches the behaviour I saw.
>
>>
>> Is this causing some problems to the CI?
>>
>
> Yes.
>
> See https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines
>
> Prior to this series, the manual actions were not used but the pipeline
> was overall in the Passed state. Specifically, they ended up being
> skipped.
>
> After this series, the manual actions are now blocking the pipeline,
> not
> letting it complete, and not marking it as passed.
one way to fix this can be to set allow_failure when in the people/*
branches, which will cause the stage to be skipped and thus mark the
pipeline as Passed when all other steps have completed. See
https://gitlab.com/xen-project/people/bugseng/xen/-/pipelines/1278550868
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
prev parent reply other threads:[~2024-05-06 6:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 15:21 [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses Federico Serafini
2024-04-29 15:21 ` [XEN PATCH 1/3] automation/eclair: tag Rule 7.2 as clean and temporarily remove Rules 1.1 and 8.2 Federico Serafini
2024-05-01 19:45 ` Stefano Stabellini
2024-04-29 15:21 ` [XEN PATCH 2/3] automation: do not allow failure for triggered analyses Federico Serafini
2024-05-01 19:45 ` Stefano Stabellini
2024-04-29 15:21 ` [XEN PATCH 3/3] automation/eclair: make explicit there are no adopted files by default Federico Serafini
2024-05-01 19:46 ` Stefano Stabellini
2024-05-03 19:14 ` [REGRESSION] Re: [XEN PATCH 0/3] automation/eclair: do not allow failure for triggered analyses Andrew Cooper
2024-05-03 19:44 ` Federico Serafini
2024-05-03 19:46 ` Andrew Cooper
2024-05-03 20:01 ` Federico Serafini
2024-05-03 20:06 ` Andrew Cooper
2024-05-06 6:45 ` Nicola Vetrini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ddfbc0d6b20238cb902ccfccb2310fc@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=consulting@bugseng.com \
--cc=federico.serafini@bugseng.com \
--cc=simone.ballarin@bugseng.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).