From: Matthew Barnes <matthew.barnes@cloud.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Matthew Barnes <matthew.barnes@cloud.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: [XEN PATCH v3] tools/lsevtchn: Use errno macro to handle hypercall error cases
Date: Wed, 8 May 2024 12:04:28 +0100 [thread overview]
Message-ID: <8bde5ee38597a86334b86822de920802483a7179.1715100071.git.matthew.barnes@cloud.com> (raw)
Currently, lsevtchn aborts its event channel enumeration when it hits
its first hypercall error, namely:
* When an event channel doesn't exist at the specified port
* When the event channel is owned by Xen
lsevtchn does not distinguish between different hypercall errors, which
results in lsevtchn missing potential relevant event channels with
higher port numbers.
Use the errno macro to distinguish between hypercall errors, and
continue event channel enumeration if the hypercall error is not
critical to enumeration.
Signed-off-by: Matthew Barnes <matthew.barnes@cloud.com>
---
tools/xcutils/lsevtchn.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/tools/xcutils/lsevtchn.c b/tools/xcutils/lsevtchn.c
index d1710613ddc5..e4b3f88fe4ec 100644
--- a/tools/xcutils/lsevtchn.c
+++ b/tools/xcutils/lsevtchn.c
@@ -3,6 +3,7 @@
#include <stdint.h>
#include <string.h>
#include <stdio.h>
+#include <errno.h>
#include <xenctrl.h>
@@ -24,7 +25,18 @@ int main(int argc, char **argv)
status.port = port;
rc = xc_evtchn_status(xch, &status);
if ( rc < 0 )
- break;
+ {
+ if ( errno == ESRCH )
+ {
+ fprintf(stderr, "Domain ID '%d' does not correspond to valid domain.\n", domid);
+ break;
+ }
+
+ if ( errno == EINVAL )
+ break;
+
+ continue;
+ }
if ( status.status == EVTCHNSTAT_closed )
continue;
--
2.34.1
next reply other threads:[~2024-05-08 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 11:04 Matthew Barnes [this message]
2024-05-14 14:15 ` [XEN PATCH v3] tools/lsevtchn: Use errno macro to handle hypercall error cases Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bde5ee38597a86334b86822de920802483a7179.1715100071.git.matthew.barnes@cloud.com \
--to=matthew.barnes@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).