* [PATCH] x86emul: correct AVX512VL+VPCLMUL test descriptions
@ 2023-04-04 10:48 Jan Beulich
2023-04-04 10:57 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2023-04-04 10:48 UTC (permalink / raw
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
The stride values (based on 32-bit element size) were wrong for these
two test, yielding misleading output (especially when comparing with the
test variants also involving AVX512-VBMI2).
Also insert a missing blank on a nearby, related line.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/tests/x86_emulator/test_x86_emulator.c
+++ b/tools/tests/x86_emulator/test_x86_emulator.c
@@ -520,10 +520,10 @@ static const struct {
SIMD(VAES (EVEX/x64), avx512bw_vaes, 64),
AVX512VL(VL+VAES (x16), avx512bw_vaes, 16),
AVX512VL(VL+VAES (x32), avx512bw_vaes, 32),
- SIMD(VPCLMUL (VEX/x4), avx2_vpclmulqdq, 32),
+ SIMD(VPCLMUL (VEX/x4), avx2_vpclmulqdq, 32),
SIMD(VPCLMUL (EVEX/x8), avx512bw_vpclmulqdq, 64),
- AVX512VL(VL+VPCLMUL (x4), avx512bw_vpclmulqdq, 16),
- AVX512VL(VL+VPCLMUL (x8), avx512bw_vpclmulqdq, 32),
+ AVX512VL(VL+VPCLMUL (x2), avx512bw_vpclmulqdq, 16),
+ AVX512VL(VL+VPCLMUL (x4), avx512bw_vpclmulqdq, 32),
SIMD(AVX512_VBMI2+VPCLMUL (x8), avx512vbmi2_vpclmulqdq, 64),
AVX512VL(_VBMI2+VL+VPCLMUL (x2), avx512vbmi2_vpclmulqdq, 16),
AVX512VL(_VBMI2+VL+VPCLMUL (x4), avx512vbmi2_vpclmulqdq, 32),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86emul: correct AVX512VL+VPCLMUL test descriptions
2023-04-04 10:48 [PATCH] x86emul: correct AVX512VL+VPCLMUL test descriptions Jan Beulich
@ 2023-04-04 10:57 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2023-04-04 10:57 UTC (permalink / raw
To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Wei Liu, Roger Pau Monné
On 04/04/2023 11:48 am, Jan Beulich wrote:
> The stride values (based on 32-bit element size) were wrong for these
> two test, yielding misleading output (especially when comparing with the
> test variants also involving AVX512-VBMI2).
>
> Also insert a missing blank on a nearby, related line.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-04 10:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 10:48 [PATCH] x86emul: correct AVX512VL+VPCLMUL test descriptions Jan Beulich
2023-04-04 10:57 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).