* [PATCH] x86emul/fuzzer: re-arrange cleaning
@ 2023-04-04 6:37 Jan Beulich
2023-04-04 6:54 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2023-04-04 6:37 UTC (permalink / raw
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper, Wei Liu, Roger Pau Monné, Anthony Perard
The latter of the two commits referenced below converted x86_emulate
from a symlinked dir to a real one, holding symlinked files. Yet even
before that the split between distclean and clean was suspicious: A
similar split, removing symlinks only in distclean, doesn't exist
anywhere else in the tree afaics.
Fixes: c808475882ef ("tools/fuzz: introduce x86 instruction emulator target")
Fixes: 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
The use of FORCE also looks suspicious to me in the rules creating the
symlinks. Supposedly that's to deal with the source tree moving, but is
that really something we need to care about (and if so, here but not
elsewhere)?
--- a/tools/fuzz/x86_instruction_emulator/Makefile
+++ b/tools/fuzz/x86_instruction_emulator/Makefile
@@ -60,11 +60,11 @@ all: x86-insn-fuzz-all
.PHONY: distclean
distclean: clean
- rm -f x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
.PHONY: clean
clean:
rm -f *.a *.o $(DEPS_RM) afl-harness afl-harness-cov *.gcda *.gcno *.gcov
+ rm -rf x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
.PHONY: install
install: all
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86emul/fuzzer: re-arrange cleaning
2023-04-04 6:37 [PATCH] x86emul/fuzzer: re-arrange cleaning Jan Beulich
@ 2023-04-04 6:54 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2023-04-04 6:54 UTC (permalink / raw
To: Jan Beulich, xen-devel@lists.xenproject.org
Cc: Wei Liu, Roger Pau Monné, Anthony Perard
On 04/04/2023 7:37 am, Jan Beulich wrote:
> The latter of the two commits referenced below converted x86_emulate
> from a symlinked dir to a real one, holding symlinked files. Yet even
> before that the split between distclean and clean was suspicious: A
> similar split, removing symlinks only in distclean, doesn't exist
> anywhere else in the tree afaics.
>
> Fixes: c808475882ef ("tools/fuzz: introduce x86 instruction emulator target")
> Fixes: 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-04 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 6:37 [PATCH] x86emul/fuzzer: re-arrange cleaning Jan Beulich
2023-04-04 6:54 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).