Xen-Devel Archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/setup: drop stale declarations of __bss_{start,end}[]
@ 2023-02-27  9:32 Jan Beulich
  2023-02-27 11:27 ` Andrew Cooper
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2023-02-27  9:32 UTC (permalink / raw
  To: xen-devel@lists.xenproject.org
  Cc: Andrew Cooper, Wei Liu, Roger Pau Monné

There are no references anymore as of c9a4a1c419ce ("x86/layout: Correct
Xen's idea of its own memory layout"). For what's left, switch to
"unsigned char" as here we're not dealing with strings of any kind.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -305,7 +305,7 @@ void __init discard_initial_images(void)
     initial_images = NULL;
 }
 
-extern char __init_begin[], __init_end[], __bss_start[], __bss_end[];
+extern unsigned char __init_begin[], __init_end[];
 
 static void __init init_idle_domain(void)
 {


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86/setup: drop stale declarations of __bss_{start,end}[]
  2023-02-27  9:32 [PATCH] x86/setup: drop stale declarations of __bss_{start,end}[] Jan Beulich
@ 2023-02-27 11:27 ` Andrew Cooper
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2023-02-27 11:27 UTC (permalink / raw
  To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Wei Liu, Roger Pau Monné

On 27/02/2023 9:32 am, Jan Beulich wrote:
> There are no references anymore as of c9a4a1c419ce ("x86/layout: Correct
> Xen's idea of its own memory layout"). For what's left, switch to
> "unsigned char" as here we're not dealing with strings of any kind.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-27 11:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-27  9:32 [PATCH] x86/setup: drop stale declarations of __bss_{start,end}[] Jan Beulich
2023-02-27 11:27 ` Andrew Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).