* preparations for 4.17.4
@ 2024-03-27 12:23 Jan Beulich
2024-03-27 12:33 ` Andrew Cooper
2024-05-16 8:30 ` Jan Beulich
0 siblings, 2 replies; 10+ messages in thread
From: Jan Beulich @ 2024-03-27 12:23 UTC (permalink / raw
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi
All,
the release is due in two to three weeks. Please point out backports you find
missing from the respective staging branch, but which you consider relevant.
Note that this is going to be the last Xen Project coordinated ordinary stable
release from this branch; the branch will move into security-only support mode
afterwards.
Jan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-03-27 12:23 preparations for 4.17.4 Jan Beulich
@ 2024-03-27 12:33 ` Andrew Cooper
2024-03-27 14:01 ` Andrew Cooper
2024-04-02 14:26 ` Jan Beulich
2024-05-16 8:30 ` Jan Beulich
1 sibling, 2 replies; 10+ messages in thread
From: Andrew Cooper @ 2024-03-27 12:33 UTC (permalink / raw
To: Jan Beulich, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi
On 27/03/2024 12:23 pm, Jan Beulich wrote:
> All,
>
> the release is due in two to three weeks. Please point out backports you find
> missing from the respective staging branch, but which you consider relevant.
>
> Note that this is going to be the last Xen Project coordinated ordinary stable
> release from this branch; the branch will move into security-only support mode
> afterwards.
1) livepatching of .rodata:
989556c6f8ca - xen/virtual-region: Rename the start/end fields
ef969144a425 - xen/virtual-region: Include rodata pointers
b083b1c393dc - x86/livepatch: Relax permissions on rodata too
And technically "x86/mm: fix detection of last L1 entry in
modify_xen_mappings_lite()" too but you've already backported this one.
Patching .rodata worked before Xen 4.17, and was broken (left as a TODO)
when I adjusted Xen to stop using CR0.WP=0 for patching.
2) Policy fixes:
e2d8a6522516 - x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max
policies
This is a real bugfix for a real regression we found updating from Xen
4.13 -> 4.17. It has a dependency on
5420aa165dfa - x86/cpu-policy: Hide x2APIC from PV guests
which I know you had more concern with. FWIW, I'm certain its a good
fix, and should be backported.
3) Test fixes:
0263dc9069dd - tests/resource: Fix HVM guest in !SHADOW builds
It's minor, but does make a difference for those of us who run these
tests regularly.
4) Watchdog fixes:
9e18f339830c - x86/boot: Improve the boot watchdog determination of
stuck cpus
131892e0dcc1 - x86/boot: Support the watchdog on newer AMD systems
You took "x86/boot: Fix setup_apic_nmi_watchdog() to fail more cleanly"
and the first of the two patches is in the same category IMO. The
second I also feel ok to take for the in-support releases, particularly
as all it is doing is dropping a family list.
5) Ucode scan stability (For 4.18 only)
Xen 4.18 had "x86/ucode: Refresh raw CPU policy after microcode load" in
it's .0 release, so should also gain:
cf7fe8b72dea - x86/ucode: Fix stability of the raw CPU Policy rescan
I've only noticed because I've got them both backported to 4.17 in
XenServer, but I don't think upstream wants to take that route.
~Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-03-27 12:33 ` Andrew Cooper
@ 2024-03-27 14:01 ` Andrew Cooper
2024-03-27 14:06 ` Jan Beulich
2024-04-02 14:26 ` Jan Beulich
1 sibling, 1 reply; 10+ messages in thread
From: Andrew Cooper @ 2024-03-27 14:01 UTC (permalink / raw
To: Jan Beulich, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi
On 27/03/2024 12:33 pm, Andrew Cooper wrote:
> On 27/03/2024 12:23 pm, Jan Beulich wrote:
>> All,
>>
>> the release is due in two to three weeks. Please point out backports you find
>> missing from the respective staging branch, but which you consider relevant.
>>
>> Note that this is going to be the last Xen Project coordinated ordinary stable
>> release from this branch; the branch will move into security-only support mode
>> afterwards.
> 1) livepatching of .rodata:
>
> 989556c6f8ca - xen/virtual-region: Rename the start/end fields
> ef969144a425 - xen/virtual-region: Include rodata pointers
> b083b1c393dc - x86/livepatch: Relax permissions on rodata too
>
> And technically "x86/mm: fix detection of last L1 entry in
> modify_xen_mappings_lite()" too but you've already backported this one.
>
> Patching .rodata worked before Xen 4.17, and was broken (left as a TODO)
> when I adjusted Xen to stop using CR0.WP=0 for patching.
>
>
> 2) Policy fixes:
>
> e2d8a6522516 - x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max
> policies
>
> This is a real bugfix for a real regression we found updating from Xen
> 4.13 -> 4.17. It has a dependency on
>
> 5420aa165dfa - x86/cpu-policy: Hide x2APIC from PV guests
>
> which I know you had more concern with. FWIW, I'm certain its a good
> fix, and should be backported.
>
>
> 3) Test fixes:
>
> 0263dc9069dd - tests/resource: Fix HVM guest in !SHADOW builds
>
> It's minor, but does make a difference for those of us who run these
> tests regularly.
>
>
> 4) Watchdog fixes:
>
> 9e18f339830c - x86/boot: Improve the boot watchdog determination of
> stuck cpus
> 131892e0dcc1 - x86/boot: Support the watchdog on newer AMD systems
>
> You took "x86/boot: Fix setup_apic_nmi_watchdog() to fail more cleanly"
> and the first of the two patches is in the same category IMO. The
> second I also feel ok to take for the in-support releases, particularly
> as all it is doing is dropping a family list.
>
>
> 5) Ucode scan stability (For 4.18 only)
>
> Xen 4.18 had "x86/ucode: Refresh raw CPU policy after microcode load" in
> it's .0 release, so should also gain:
>
> cf7fe8b72dea - x86/ucode: Fix stability of the raw CPU Policy rescan
>
> I've only noticed because I've got them both backported to 4.17 in
> XenServer, but I don't think upstream wants to take that route.
It occurs to me that these want considering:
b6cf604207fd - tools/oxenstored: Use Map instead of Hashtbl for quotas
098d868e52ac - tools/oxenstored: Make Quota.t pure
while 4.17 is still in general support. These came from a performance
regression we investigated.
I've done the backport to 4.17 and they're not entirely trivial (owing
to the major source reformat in 4.18) so can commit them if you'd prefer.
~Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-03-27 14:01 ` Andrew Cooper
@ 2024-03-27 14:06 ` Jan Beulich
2024-03-27 14:42 ` Andrew Cooper
0 siblings, 1 reply; 10+ messages in thread
From: Jan Beulich @ 2024-03-27 14:06 UTC (permalink / raw
To: Andrew Cooper
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi,
xen-devel@lists.xenproject.org, Christian Lindig, David Scott
On 27.03.2024 15:01, Andrew Cooper wrote:
> It occurs to me that these want considering:
>
> b6cf604207fd - tools/oxenstored: Use Map instead of Hashtbl for quotas
> 098d868e52ac - tools/oxenstored: Make Quota.t pure
>
> while 4.17 is still in general support. These came from a performance
> regression we investigated.
>
> I've done the backport to 4.17 and they're not entirely trivial (owing
> to the major source reformat in 4.18) so can commit them if you'd prefer.
Didn't you bring these up for 4.18.1 already, and I said that I'd leave
this for the maintainers to decide? Same here, in any event. Cc-ing them
both, just in case.
Jan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-03-27 14:06 ` Jan Beulich
@ 2024-03-27 14:42 ` Andrew Cooper
2024-03-27 15:29 ` Christian Lindig
0 siblings, 1 reply; 10+ messages in thread
From: Andrew Cooper @ 2024-03-27 14:42 UTC (permalink / raw
To: Jan Beulich
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi,
xen-devel@lists.xenproject.org, Christian Lindig, David Scott
On 27/03/2024 2:06 pm, Jan Beulich wrote:
> On 27.03.2024 15:01, Andrew Cooper wrote:
>> It occurs to me that these want considering:
>>
>> b6cf604207fd - tools/oxenstored: Use Map instead of Hashtbl for quotas
>> 098d868e52ac - tools/oxenstored: Make Quota.t pure
>>
>> while 4.17 is still in general support. These came from a performance
>> regression we investigated.
>>
>> I've done the backport to 4.17 and they're not entirely trivial (owing
>> to the major source reformat in 4.18) so can commit them if you'd prefer.
> Didn't you bring these up for 4.18.1 already, and I said that I'd leave
> this for the maintainers to decide? Same here, in any event. Cc-ing them
> both, just in case.
I could have sworn that I remembered requested this before, but couldn't
remember where.
I'll see about poking people for an answer.
~Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-03-27 14:42 ` Andrew Cooper
@ 2024-03-27 15:29 ` Christian Lindig
0 siblings, 0 replies; 10+ messages in thread
From: Christian Lindig @ 2024-03-27 15:29 UTC (permalink / raw
To: Andrew Cooper
Cc: Jan Beulich, Stefano Stabellini, Anthony Perard, Julien Grall,
Kelly Choi, xen-devel@lists.xenproject.org, David Scott
> On 27 Mar 2024, at 14:42, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> On 27/03/2024 2:06 pm, Jan Beulich wrote:
>> On 27.03.2024 15:01, Andrew Cooper wrote:
>>> It occurs to me that these want considering:
>>>
>>> b6cf604207fd - tools/oxenstored: Use Map instead of Hashtbl for quotas
>>> 098d868e52ac - tools/oxenstored: Make Quota.t pure
>>>
>>> while 4.17 is still in general support. These came from a performance
>>> regression we investigated.
>>>
>>> I've done the backport to 4.17 and they're not entirely trivial (owing
>>> to the major source reformat in 4.18) so can commit them if you'd prefer.
>> Didn't you bring these up for 4.18.1 already, and I said that I'd leave
>> this for the maintainers to decide? Same here, in any event. Cc-ing them
>> both, just in case.
>
> I could have sworn that I remembered requested this before, but couldn't
> remember where.
>
> I'll see about poking people for an answer.
>
> ~Andrew
I understand we have backport; so I support upstreaming it.
— C
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-03-27 12:33 ` Andrew Cooper
2024-03-27 14:01 ` Andrew Cooper
@ 2024-04-02 14:26 ` Jan Beulich
2024-04-03 14:08 ` Andrew Cooper
1 sibling, 1 reply; 10+ messages in thread
From: Jan Beulich @ 2024-04-02 14:26 UTC (permalink / raw
To: Andrew Cooper
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi,
xen-devel@lists.xenproject.org
On 27.03.2024 13:33, Andrew Cooper wrote:
> 1) livepatching of .rodata:
>
> 989556c6f8ca - xen/virtual-region: Rename the start/end fields
> ef969144a425 - xen/virtual-region: Include rodata pointers
> b083b1c393dc - x86/livepatch: Relax permissions on rodata too
>
> And technically "x86/mm: fix detection of last L1 entry in
> modify_xen_mappings_lite()" too but you've already backported this one.
>
> Patching .rodata worked before Xen 4.17, and was broken (left as a TODO)
> when I adjusted Xen to stop using CR0.WP=0 for patching.
>
>
> 2) Policy fixes:
>
> e2d8a6522516 - x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max
> policies
>
> This is a real bugfix for a real regression we found updating from Xen
> 4.13 -> 4.17. It has a dependency on
>
> 5420aa165dfa - x86/cpu-policy: Hide x2APIC from PV guests
>
> which I know you had more concern with. FWIW, I'm certain its a good
> fix, and should be backported.
>
>
> 3) Test fixes:
>
> 0263dc9069dd - tests/resource: Fix HVM guest in !SHADOW builds
>
> It's minor, but does make a difference for those of us who run these
> tests regularly.
>
>
> 4) Watchdog fixes:
>
> 9e18f339830c - x86/boot: Improve the boot watchdog determination of
> stuck cpus
> 131892e0dcc1 - x86/boot: Support the watchdog on newer AMD systems
>
> You took "x86/boot: Fix setup_apic_nmi_watchdog() to fail more cleanly"
> and the first of the two patches is in the same category IMO. The
> second I also feel ok to take for the in-support releases, particularly
> as all it is doing is dropping a family list.
I've pushed all of the above.
> 5) Ucode scan stability (For 4.18 only)
>
> Xen 4.18 had "x86/ucode: Refresh raw CPU policy after microcode load" in
> it's .0 release, so should also gain:
>
> cf7fe8b72dea - x86/ucode: Fix stability of the raw CPU Policy rescan
This already is in 4.18.1, ...
> I've only noticed because I've got them both backported to 4.17 in
> XenServer, but I don't think upstream wants to take that route.
... while, as you suggest, not (and not intended to be) in 4.17.
Jan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-04-02 14:26 ` Jan Beulich
@ 2024-04-03 14:08 ` Andrew Cooper
2024-04-03 14:23 ` Jan Beulich
0 siblings, 1 reply; 10+ messages in thread
From: Andrew Cooper @ 2024-04-03 14:08 UTC (permalink / raw
To: Jan Beulich
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi,
xen-devel@lists.xenproject.org
On 02/04/2024 3:26 pm, Jan Beulich wrote:
> On 27.03.2024 13:33, Andrew Cooper wrote:
>> 1) livepatching of .rodata:
>>
>> 989556c6f8ca - xen/virtual-region: Rename the start/end fields
>> ef969144a425 - xen/virtual-region: Include rodata pointers
>> b083b1c393dc - x86/livepatch: Relax permissions on rodata too
>>
>> And technically "x86/mm: fix detection of last L1 entry in
>> modify_xen_mappings_lite()" too but you've already backported this one.
>>
>> Patching .rodata worked before Xen 4.17, and was broken (left as a TODO)
>> when I adjusted Xen to stop using CR0.WP=0 for patching.
>>
>>
>> 2) Policy fixes:
>>
>> e2d8a6522516 - x86/cpu-policy: Fix visibility of HTT/CMP_LEGACY in max
>> policies
>>
>> This is a real bugfix for a real regression we found updating from Xen
>> 4.13 -> 4.17. It has a dependency on
>>
>> 5420aa165dfa - x86/cpu-policy: Hide x2APIC from PV guests
>>
>> which I know you had more concern with. FWIW, I'm certain its a good
>> fix, and should be backported.
>>
>>
>> 3) Test fixes:
>>
>> 0263dc9069dd - tests/resource: Fix HVM guest in !SHADOW builds
>>
>> It's minor, but does make a difference for those of us who run these
>> tests regularly.
>>
>>
>> 4) Watchdog fixes:
>>
>> 9e18f339830c - x86/boot: Improve the boot watchdog determination of
>> stuck cpus
>> 131892e0dcc1 - x86/boot: Support the watchdog on newer AMD systems
>>
>> You took "x86/boot: Fix setup_apic_nmi_watchdog() to fail more cleanly"
>> and the first of the two patches is in the same category IMO. The
>> second I also feel ok to take for the in-support releases, particularly
>> as all it is doing is dropping a family list.
> I've pushed all of the above.
Thanks.
>
>> 5) Ucode scan stability (For 4.18 only)
>>
>> Xen 4.18 had "x86/ucode: Refresh raw CPU policy after microcode load" in
>> it's .0 release, so should also gain:
>>
>> cf7fe8b72dea - x86/ucode: Fix stability of the raw CPU Policy rescan
> This already is in 4.18.1, ...
>
>> I've only noticed because I've got them both backported to 4.17 in
>> XenServer, but I don't think upstream wants to take that route.
> ... while, as you suggest, not (and not intended to be) in 4.17.
Oh, so it is. Although comparing my backport to what you put into 4.18,
you also want
930605f155cc - x86/ucode: Remove accidentally introduced tabs
which I apparently folded into my 4.17 backport. I have a feeling I
noticed at the point of doing the backport.
~Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-04-03 14:08 ` Andrew Cooper
@ 2024-04-03 14:23 ` Jan Beulich
0 siblings, 0 replies; 10+ messages in thread
From: Jan Beulich @ 2024-04-03 14:23 UTC (permalink / raw
To: Andrew Cooper
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi,
xen-devel@lists.xenproject.org
On 03.04.2024 16:08, Andrew Cooper wrote:
> On 02/04/2024 3:26 pm, Jan Beulich wrote:
>> On 27.03.2024 13:33, Andrew Cooper wrote:
>>> 5) Ucode scan stability (For 4.18 only)
>>>
>>> Xen 4.18 had "x86/ucode: Refresh raw CPU policy after microcode load" in
>>> it's .0 release, so should also gain:
>>>
>>> cf7fe8b72dea - x86/ucode: Fix stability of the raw CPU Policy rescan
>> This already is in 4.18.1, ...
>>
>>> I've only noticed because I've got them both backported to 4.17 in
>>> XenServer, but I don't think upstream wants to take that route.
>> ... while, as you suggest, not (and not intended to be) in 4.17.
>
> Oh, so it is. Although comparing my backport to what you put into 4.18,
> you also want
>
> 930605f155cc - x86/ucode: Remove accidentally introduced tabs
>
> which I apparently folded into my 4.17 backport. I have a feeling I
> noticed at the point of doing the backport.
Well, no, if need be that can be folded into a future backport touching
that area again.
Jan
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: preparations for 4.17.4
2024-03-27 12:23 preparations for 4.17.4 Jan Beulich
2024-03-27 12:33 ` Andrew Cooper
@ 2024-05-16 8:30 ` Jan Beulich
1 sibling, 0 replies; 10+ messages in thread
From: Jan Beulich @ 2024-05-16 8:30 UTC (permalink / raw
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini, Anthony Perard, Julien Grall, Kelly Choi
On 27.03.2024 13:23, Jan Beulich wrote:
> the release is due in two to three weeks. Please point out backports you find
> missing from the respective staging branch, but which you consider relevant.
>
> Note that this is going to be the last Xen Project coordinated ordinary stable
> release from this branch; the branch will move into security-only support mode
> afterwards.
Noticing only now: This was premature; there ought to be a regular 4.17.5, as
full support extends up until early June. I have no idea where I was looking
when deciding to write the above.
Jan
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-05-16 8:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-27 12:23 preparations for 4.17.4 Jan Beulich
2024-03-27 12:33 ` Andrew Cooper
2024-03-27 14:01 ` Andrew Cooper
2024-03-27 14:06 ` Jan Beulich
2024-03-27 14:42 ` Andrew Cooper
2024-03-27 15:29 ` Christian Lindig
2024-04-02 14:26 ` Jan Beulich
2024-04-03 14:08 ` Andrew Cooper
2024-04-03 14:23 ` Jan Beulich
2024-05-16 8:30 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).