From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state
Date: Fri, 17 May 2024 15:56:05 +0200 [thread overview]
Message-ID: <20240517135605.94781-1-roger.pau@citrix.com> (raw)
Use the same check that's used in dump_irqs().
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
xen/arch/x86/msi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 19830528b65a..0c97fbb3fc03 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -17,6 +17,7 @@
#include <xen/param.h>
#include <xen/pci.h>
#include <xen/pci_regs.h>
+#include <xen/softirq.h>
#include <xen/iocap.h>
#include <xen/keyhandler.h>
#include <xen/pfn.h>
@@ -1451,6 +1452,9 @@ static void cf_check dump_msi(unsigned char key)
unsigned long flags;
const char *type = "???";
+ if ( !(irq & 0x1f) )
+ process_pending_softirqs();
+
if ( !irq_desc_initialized(desc) )
continue;
--
2.44.0
next reply other threads:[~2024-05-17 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 13:56 Roger Pau Monne [this message]
2024-05-20 7:46 ` [PATCH for-4.19] x86/msi: prevent watchdog triggering when dumping MSI state Oleksii K.
2024-05-20 13:15 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517135605.94781-1-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).