From: Christoph Hellwig <hch@lst.de>
To: mhklinux@outlook.com
Cc: robin.murphy@arm.com, joro@8bytes.org, will@kernel.org,
jgross@suse.com, sstabellini@kernel.org,
oleksandr_tyshchenko@epam.com, hch@lst.de,
m.szyprowski@samsung.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
petr@tesarici.cz, roberto.sassu@huaweicloud.com
Subject: Re: [PATCH 2/2] iommu/dma: Fix zero'ing of bounce buffer padding used by untrusted devices
Date: Tue, 7 May 2024 07:36:04 +0200 [thread overview]
Message-ID: <20240507053604.GA31731@lst.de> (raw)
In-Reply-To: <20240408041142.665563-2-mhklinux@outlook.com>
On Sun, Apr 07, 2024 at 09:11:42PM -0700, mhkelley58@gmail.com wrote:
> I've wondered if this code for zero'ing the pre- and post-padding
> should go in swiotlb_tbl_map_single(). The bounce buffer proper is
> already being initialized there. But swiotlb_tbl_map_single()
> would need to test for an untrusted device (or have a "zero the
> padding" flag passed in as part of the "attrs" argument), which
> adds complexity. Thoughts?
If we want to go down that route it should be the latter. I'm
not sure if it is an improvement, but we'd have to implement it
to see if it does.
> The commit ID of Petr's patch is X'ed out above because Petr's patch
> hasn't gone into Linus' tree yet. We can add the real commit ID once
> this patch is ready to go in.
I've fixed that up and commit the series.
Thanks a lot!
next prev parent reply other threads:[~2024-05-07 5:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 4:11 [PATCH 1/2] swiotlb: Remove alloc_size argument to swiotlb_tbl_map_single() mhkelley58
2024-04-08 4:11 ` [PATCH 2/2] iommu/dma: Fix zero'ing of bounce buffer padding used by untrusted devices mhkelley58
2024-05-06 15:48 ` Petr Tesařík
2024-05-07 5:36 ` Christoph Hellwig [this message]
2024-04-15 11:46 ` [PATCH 1/2] swiotlb: Remove alloc_size argument to swiotlb_tbl_map_single() Petr Tesařík
2024-04-15 12:23 ` Michael Kelley
2024-04-15 12:50 ` Petr Tesařík
2024-04-15 13:03 ` Michael Kelley
2024-04-15 13:19 ` Petr Tesařík
2024-05-06 15:14 ` Michael Kelley
2024-05-06 15:35 ` Petr Tesařík
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507053604.GA31731@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhklinux@outlook.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=petr@tesarici.cz \
--cc=roberto.sassu@huaweicloud.com \
--cc=robin.murphy@arm.com \
--cc=sstabellini@kernel.org \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).