From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com,
michal.orzel@amd.com, Volodymyr_Babchuk@epam.com,
jbeulich@suse.com, andrew.cooper3@citrix.com,
edgar.iglesias@amd.com
Subject: [PATCH v2 0/1] xen/arm: Annotate code symbols
Date: Tue, 16 Apr 2024 01:15:40 +0200 [thread overview]
Message-ID: <20240415231541.4140052-1-edgar.iglesias@gmail.com> (raw)
From: "Edgar E. Iglesias" <edgar.iglesias@amd.com>
On the way towards Xen safety certification we're evaluating the use
of tools to collect code-coverage/profiling information from execution
traces. Some tools rely on ELF symbols for code being declared with
type FUNC and having a symbol size.
We currently annotate some symbols but not all. Also, there seems to be
different ways to do the annotation so I'm sending out this series to
first figure out how we want to do things before I go ahead and edit
more of the ARM port.
In this first try I've followed the style from commit:
b3a9037550 x86: annotate entry points with type and size
IIUC, prefering to use macros from the generic framework in
xen/linkage.h in favor of ENTRY/ENDPROC.
But perhaps we would like to keep using ENTRY() for entry points
into the hypervisor?
Another way could be to add .type name, %function to the ENTRY macro
and use END from xen/linkage.h.
Or we can keep using ENTRY/GLOBAL/ENDPROC.
Any thoughts or better ideas?
Best regards,
Edgar
ChangeLog:
v1 -> v2:
* Drop RFC.
* Squash into a single patch to avoid confusion.
Edgar E. Iglesias (1):
xen/arm64: entry: Add missing code symbol annotations
xen/arch/arm/arm64/entry.S | 72 +++++++++++++++++++++++++-------------
1 file changed, 48 insertions(+), 24 deletions(-)
--
2.40.1
next reply other threads:[~2024-04-16 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 23:15 Edgar E. Iglesias [this message]
2024-04-15 23:15 ` [PATCH v2 1/1] xen/arm64: entry: Add missing code symbol annotations Edgar E. Iglesias
2024-04-25 23:13 ` Stefano Stabellini
2024-04-26 6:02 ` Jan Beulich
2024-04-26 19:13 ` Stefano Stabellini
2024-05-02 16:38 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415231541.4140052-1-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=edgar.iglesias@amd.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).