From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <George.Dunlap@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Daniel Smith <dpsmith@apertussolutions.com>
Subject: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"
Date: Tue, 2 Apr 2024 18:06:12 +0100 [thread overview]
Message-ID: <20240402170612.2477791-1-andrew.cooper3@citrix.com> (raw)
The commit makes a claim without any kind of justification.
The claim is false, and the commit broke lsevtchn in dom0. It is also quite
obvious from XSM_TARGET that it has broken device model stubdoms too.
Whether to return information about a xen-owned evtchn is a matter of policy,
and it's not acceptable to short circuit the XSM on the matter.
This reverts commit f60ab5337f968e2f10c639ab59db7afb0fe4f7c3.
Fixes: f60ab5337f96 ("evtchn: refuse EVTCHNOP_status for Xen-bound event channels")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <George.Dunlap@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Daniel Smith <dpsmith@apertussolutions.com>
---
xen/common/event_channel.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index 20f586cf5ecd..ae6c2f902645 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -1040,12 +1040,6 @@ int evtchn_status(evtchn_status_t *status)
read_lock(&d->event_lock);
- if ( consumer_is_xen(chn) )
- {
- rc = -EACCES;
- goto out;
- }
-
rc = xsm_evtchn_status(XSM_TARGET, d, chn);
if ( rc )
goto out;
base-commit: 7a09966e7b2823b70f6d56d0cf66c11124f4a3c1
--
2.30.2
next reply other threads:[~2024-04-02 17:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 17:06 Andrew Cooper [this message]
2024-04-03 6:16 ` [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels" Jan Beulich
2024-04-03 6:52 ` Jan Beulich
2024-04-03 11:50 ` Daniel P. Smith
2024-04-03 11:54 ` Jan Beulich
2024-04-03 13:31 ` Daniel P. Smith
2024-04-04 8:11 ` Jan Beulich
2024-04-03 11:10 ` Daniel P. Smith
2024-04-03 12:05 ` Jan Beulich
2024-04-03 13:27 ` Daniel P. Smith
2024-04-04 7:57 ` Jan Beulich
2024-04-05 5:59 ` Jan Beulich
2024-05-14 9:25 ` Jan Beulich
2024-05-14 9:51 ` Andrew Cooper
2024-05-14 10:03 ` Jan Beulich
2024-05-14 11:13 ` Julien Grall
2024-05-14 21:35 ` Stefano Stabellini
2024-05-15 7:33 ` Jan Beulich
2024-05-16 19:15 ` Oleksii K.
2024-05-17 7:01 ` Jan Beulich
2024-05-15 10:49 ` Kelly Choi
2024-05-15 12:59 ` George Dunlap
2024-05-16 6:41 ` Jan Beulich
2024-05-17 1:21 ` Stefano Stabellini
2024-05-17 7:04 ` Jan Beulich
2024-05-17 20:28 ` Stefano Stabellini
2024-05-21 6:17 ` Jan Beulich
2024-05-22 1:33 ` Stefano Stabellini
2024-05-17 1:22 ` Daniel P. Smith
2024-05-17 7:24 ` Jan Beulich
2024-04-03 13:35 ` Daniel P. Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402170612.2477791-1-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=dpsmith@apertussolutions.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).