From: Luca Fancellu <Luca.Fancellu@arm.com>
To: Julien Grall <julien@xen.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <Bertrand.Marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem
Date: Tue, 14 May 2024 07:53:25 +0000 [thread overview]
Message-ID: <0A931CEA-59CA-4B1F-A8E4-A4CB990C0476@arm.com> (raw)
In-Reply-To: <a9629975-87d1-457b-b6aa-cbeb91fd4854@xen.org>
Hi Julien,
Thanks for having a look on the patch,
> On 13 May 2024, at 22:54, Julien Grall <julien@xen.org> wrote:
>
> Hi Luca,
>
> On 25/04/2024 14:11, Luca Fancellu wrote:
>> Currently the code is listing device tree reserve map regions
>> as reserved memory for Xen, but they are not added into
>> bootinfo.reserved_mem and they are fetched in multiple places
>> using the same code sequence, causing duplication. Fix this
>> by adding them to the bootinfo.reserved_mem at early stage.
>
> Do we have enough space in bootinfo.reserved_mem for them?
So we have 255 banks, in my experience I would say I’ve never saw too many reserved regions
in the DT, maybe a couple, but I’ve always had to deal with embedded platforms.
I’ve tested this one with ADLINK AVA board, n1sdp, Juno, raspberry pi, qemu, fvp.
In your experience, have you seen any numbers that could be concerning?
Cheers,
Luca
next prev parent reply other threads:[~2024-05-14 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 13:11 [RFC PATCH 0/2] xen/arm: Remove recursion from dt_unreserved_regions Luca Fancellu
2024-04-25 13:11 ` [RFC PATCH 1/2] xen/arm: Add DT reserve map regions to bootinfo.reserved_mem Luca Fancellu
2024-05-13 21:54 ` Julien Grall
2024-05-14 7:53 ` Luca Fancellu [this message]
2024-05-14 21:06 ` Julien Grall
2024-05-15 10:05 ` Luca Fancellu
2024-05-16 21:23 ` Julien Grall
2024-04-25 13:11 ` [RFC PATCH 2/2] xen/arm: Rework dt_unreserved_regions to avoid recursion Luca Fancellu
2024-05-13 22:16 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0A931CEA-59CA-4B1F-A8E4-A4CB990C0476@arm.com \
--to=luca.fancellu@arm.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).