* [PATCH] x86/Xen: drop leftover VM-assist uses
@ 2023-02-15 11:27 Jan Beulich
2023-02-16 7:26 ` Juergen Gross
2023-02-16 13:46 ` Andrew Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2023-02-15 11:27 UTC (permalink / raw
To: xen-devel@lists.xenproject.org; +Cc: Juergen Gross, Boris Ostrovsky
Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to
32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant
with the PAE_MODE ELF note anyway.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -934,12 +934,8 @@ void xen_enable_syscall(void)
static void __init xen_pvmmu_arch_setup(void)
{
- HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_4gb_segments);
HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_writable_pagetables);
- HYPERVISOR_vm_assist(VMASST_CMD_enable,
- VMASST_TYPE_pae_extended_cr3);
-
if (register_callback(CALLBACKTYPE_event,
xen_asm_exc_xen_hypervisor_callback) ||
register_callback(CALLBACKTYPE_failsafe, xen_failsafe_callback))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/Xen: drop leftover VM-assist uses
2023-02-15 11:27 [PATCH] x86/Xen: drop leftover VM-assist uses Jan Beulich
@ 2023-02-16 7:26 ` Juergen Gross
2023-02-16 13:46 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2023-02-16 7:26 UTC (permalink / raw
To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Boris Ostrovsky
[-- Attachment #1.1.1: Type: text/plain, Size: 342 bytes --]
On 15.02.23 12:27, Jan Beulich wrote:
> Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to
> 32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant
> with the PAE_MODE ELF note anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/Xen: drop leftover VM-assist uses
2023-02-15 11:27 [PATCH] x86/Xen: drop leftover VM-assist uses Jan Beulich
2023-02-16 7:26 ` Juergen Gross
@ 2023-02-16 13:46 ` Andrew Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2023-02-16 13:46 UTC (permalink / raw
To: Jan Beulich, xen-devel@lists.xenproject.org
Cc: Juergen Gross, Boris Ostrovsky
On 15/02/2023 11:27 am, Jan Beulich wrote:
> Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to
> 32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant
> with the PAE_MODE ELF note anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -934,12 +934,8 @@ void xen_enable_syscall(void)
>
> static void __init xen_pvmmu_arch_setup(void)
> {
> - HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_4gb_segments);
> HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_writable_pagetables);
I find it disappointing that a PV guest which states a hard dependency
on writeable pagetables in its elfnotes doesn't have this activated
automatically.
The PV API/ABI truly is an undesigned mess.
~Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-16 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 11:27 [PATCH] x86/Xen: drop leftover VM-assist uses Jan Beulich
2023-02-16 7:26 ` Juergen Gross
2023-02-16 13:46 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).