From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>,
magnus.karlsson@intel.com, bjorn@kernel.org, ast@kernel.org,
daniel@iogearbox.net, netdev@vger.kernel.org,
maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com,
andrii@kernel.org, hawk@kernel.org, toke@redhat.com
Cc: brouer@redhat.com, bpf@vger.kernel.org,
Xdp <xdp-newbies@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests, bpf: remove AF_XDP samples
Date: Thu, 30 Jun 2022 15:44:53 +0200 [thread overview]
Message-ID: <fa929729-6122-195f-aa4b-e5d3fedb1887@redhat.com> (raw)
In-Reply-To: <20220630093717.8664-1-magnus.karlsson@gmail.com>
On 30/06/2022 11.37, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Remove the AF_XDP samples from samples/bpf as they are dependent on
> the AF_XDP support in libbpf. This support has now been removed in the
> 1.0 release, so these samples cannot be compiled anymore. Please start
> to use libxdp instead. It is backwards compatible with the AF_XDP
> support that was offered in libbpf. New samples can be found in the
> various xdp-project repositories connected to libxdp and by googling.
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Will you (or Maciej) be submitting these samples to XDP-tools[1] which
is the current home for libxdp or maybe BPF-examples[2] ?
[1] https://github.com/xdp-project/xdp-tools
[2] https://github.com/xdp-project/bpf-examples
I know Toke is ready to take over maintaining these, but we will
appreciate someone to open a PR with this code...
> ---
> MAINTAINERS | 2 -
> samples/bpf/Makefile | 9 -
> samples/bpf/xdpsock.h | 19 -
> samples/bpf/xdpsock_ctrl_proc.c | 190 ---
> samples/bpf/xdpsock_kern.c | 24 -
> samples/bpf/xdpsock_user.c | 2019 -------------------------------
> samples/bpf/xsk_fwd.c | 1085 -----------------
The code in samples/bpf/xsk_fwd.c is interesting, because it contains a
buffer memory manager, something I've seen people struggle with getting
right and performant (at the same time).
You can get my ACK if someone commits to port this to [1] or [2], or a
3rd place that have someone what will maintain this in the future.
--Jesper
next parent reply other threads:[~2022-06-30 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220630093717.8664-1-magnus.karlsson@gmail.com>
2022-06-30 13:44 ` Jesper Dangaard Brouer [this message]
2022-06-30 14:20 ` [PATCH bpf-next] selftests, bpf: remove AF_XDP samples Magnus Karlsson
2022-07-01 12:15 ` Toke Høiland-Jørgensen
2022-07-01 13:04 ` Srivats P
2022-07-01 13:16 ` Magnus Karlsson
2022-07-04 18:44 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa929729-6122-195f-aa4b-e5d3fedb1887@redhat.com \
--to=jbrouer@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).