From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Lorenzo Bianconi <lorenzo@kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Xdp <xdp-newbies@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 1/3] samples: bpf: Refactor xdp_monitor with libbpf
Date: Sat, 10 Oct 2020 16:56:27 -0700 [thread overview]
Message-ID: <CAEf4BzZw3Se=qa=hjrtLtL4AEq7UQcmS-ZdKqo=qAHO1Kn=SGA@mail.gmail.com> (raw)
In-Reply-To: <20201010181734.1109-2-danieltimlee@gmail.com>
On Sat, Oct 10, 2020 at 11:17 AM Daniel T. Lee <danieltimlee@gmail.com> wrote:
>
> To avoid confusion caused by the increasing fragmentation of the BPF
> Loader program, this commit would like to change to the libbpf loader
> instead of using the bpf_load.
>
> Thanks to libbpf's bpf_link interface, managing the tracepoint BPF
> program is much easier. bpf_program__attach_tracepoint manages the
> enable of tracepoint event and attach of BPF programs to it with a
> single interface bpf_link, so there is no need to manage event_fd and
> prog_fd separately.
>
> This commit refactors xdp_monitor with using this libbpf API, and the
> bpf_load is removed and migrated to libbpf.
>
> Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
>
> ---
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> Changes in v2:
> - added cleanup logic for bpf_link and bpf_object
> - split increment into seperate satement
> - refactor pointer array initialization
>
> samples/bpf/Makefile | 2 +-
> samples/bpf/xdp_monitor_user.c | 159 +++++++++++++++++++++++++--------
> 2 files changed, 121 insertions(+), 40 deletions(-)
>
[...]
next prev parent reply other threads:[~2020-10-10 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 18:17 [PATCH bpf-next v2 0/3] samples: bpf: Refactor XDP programs with libbpf Daniel T. Lee
2020-10-10 18:17 ` [PATCH bpf-next v2 1/3] samples: bpf: Refactor xdp_monitor " Daniel T. Lee
2020-10-10 23:56 ` Andrii Nakryiko [this message]
2020-10-10 18:17 ` [PATCH bpf-next v2 2/3] samples: bpf: Replace attach_tracepoint() to attach() in xdp_redirect_cpu Daniel T. Lee
2020-10-10 23:55 ` Andrii Nakryiko
2020-10-10 18:17 ` [PATCH bpf-next v2 3/3] samples: bpf: refactor XDP kern program maps with BTF-defined map Daniel T. Lee
2020-10-10 23:56 ` Andrii Nakryiko
-- strict thread matches above, loose matches on Subject: below --
2020-10-10 10:44 [PATCH bpf-next v2 0/3] samples: bpf: Refactor XDP programs with libbpf Daniel T. Lee
2020-10-10 10:44 ` [PATCH bpf-next v2 1/3] samples: bpf: Refactor xdp_monitor " Daniel T. Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzZw3Se=qa=hjrtLtL4AEq7UQcmS-ZdKqo=qAHO1Kn=SGA@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=danieltimlee@gmail.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).